Skip to content

Add migration http transport for push/sync mirror lfs#36665

Merged
lunny merged 4 commits intogo-gitea:mainfrom
lunny:lunny/fix_lfs_client
Feb 20, 2026
Merged

Add migration http transport for push/sync mirror lfs#36665
lunny merged 4 commits intogo-gitea:mainfrom
lunny:lunny/fix_lfs_client

Conversation

@lunny
Copy link
Copy Markdown
Member

@lunny lunny commented Feb 18, 2026

No description provided.

@lunny lunny added type/bug backport/v1.25 This PR should be backported to Gitea 1.25 labels Feb 18, 2026
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 18, 2026
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Feb 18, 2026
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 18, 2026
@silverwind silverwind requested a review from Copilot February 18, 2026 02:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates LFS client initialization in mirror operations (both push and pull) to use the migration HTTP transport instead of the default transport. This change ensures that mirror LFS operations respect the same security and configuration settings as repository migrations.

Changes:

  • Mirror push LFS operations now use migrations.NewMigrationHTTPTransport() instead of nil
  • Mirror pull LFS operations now use migrations.NewMigrationHTTPTransport() instead of nil

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
services/mirror/mirror_push.go Updated LFS client initialization in push mirror sync to use migration HTTP transport
services/mirror/mirror_pull.go Updated LFS client initialization in pull mirror sync to use migration HTTP transport

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 20, 2026
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 20, 2026
@lunny lunny enabled auto-merge (squash) February 20, 2026 22:00
@lunny lunny merged commit bcd253a into go-gitea:main Feb 20, 2026
24 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Feb 20, 2026
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 20, 2026
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Feb 20, 2026
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Feb 20, 2026
@lunny lunny deleted the lunny/fix_lfs_client branch February 20, 2026 23:06
silverwind pushed a commit that referenced this pull request Feb 22, 2026
Backport #36665 by @lunny

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 23, 2026
* giteaofficial/main: (81 commits)
  Add keyboard shortcuts for repository file and code search (go-gitea#36416)
  Refactor text utility classes to Tailwind CSS (go-gitea#36703)
  Prevent redirect bypasses via backslash-encoded paths (go-gitea#36660)
  Fix force push time-line commit comments of pull request (go-gitea#36653)
  Fix get release draft permission check (go-gitea#36659)
  Move `X_FRAME_OPTIONS` setting from `cors` to `security` section (go-gitea#30256)
  Update JS and PY deps (go-gitea#36708)
  Move jobparser from act repository to Gitea (go-gitea#36699)
  Fix push time bug (go-gitea#36693)
  Add icon to buttons "Close with Comment", "Close Pull Request", "Close Issue" (go-gitea#36654)
  various fixes (go-gitea#36697)
  Add AI Contribution Policy to CONTRIBUTING.md (go-gitea#36651)
  Add some validation on values provided to USER_DISABLED_FEATURES and EXTERNAL_USER_DISABLED_FEATURES (go-gitea#36688)
  Rework e2e tests (go-gitea#36634)
  Remove unused functions (go-gitea#36672)
  Add migration http transport for push/sync mirror lfs (go-gitea#36665)
  Fix track time issue id (go-gitea#36664)
  Refactor inline style attributes (go-gitea#36652)
  Update Nix flake (go-gitea#36679)
  Upgrade gogit to 5.16.5 (go-gitea#36680)
  ...

# Conflicts:
#	web_src/js/features/repo-issue-content.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/done All backports for this PR have been created backport/v1.25 This PR should be backported to Gitea 1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants