Conversation
7236902 to
876b328
Compare
876b328 to
84366f2
Compare
There was a problem hiding this comment.
Pull request overview
This pull request fixes four distinct bugs across URL encoding, issue search navigation, and markdown rendering of commit links.
Changes:
- Fixed OAuth2 authentication redirect URL encoding to properly handle special characters like apostrophes per RFC 3986
- Restored issue list Quick Goto functionality to allow cross-repository navigation and fixed form submission behavior
- Fixed markdown rendering of commit archive and patch URLs to preserve file extensions like
.tar.gz,.patch, and.diff
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| web_src/js/utils.ts | Added RFC 3986-compliant URL query escape function |
| web_src/js/utils.test.ts | Added test coverage for URL query escaping |
| web_src/js/features/common-issue-list.ts | Refactored Quick Goto to use click handler and allow global search |
| web_src/js/features/common-issue-list.test.ts | Updated tests to reflect new cross-repo navigation capability |
| web_src/js/features/admin/common.ts | Applied proper URL encoding for OAuth2 callback URLs |
| web_src/css/base.css | Changed inline code background to use semantic CSS variable |
| templates/repo/issue/search.tmpl | Updated Quick Goto button to use explicit button type and visible label |
| options/locale/locale_en-US.json | Added translation string for Quick Goto button |
| modules/templates/helper_test.go | Added Go test to verify query escaping matches JS implementation |
| modules/markup/html_test.go | Added tests for commit URLs with file extensions |
| modules/markup/html_commit.go | Enhanced commit URL parsing to extract file extensions |
| modules/markup/html.go | Updated regex pattern to capture file extensions after commit hashes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: silverwind <me@silverwind.io> Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
|
I was unable to create a backport for 1.25. @wxiaoguang, please send one manually. 🍵 |
* giteaofficial/main: Normalize guessed languages for code highlighting (go-gitea#36450) Add `knip` linter (go-gitea#36442) Fix various bugs (go-gitea#36446) Update tool dependencies (go-gitea#36445) Update JS dependencies, adjust webpack config, misc fixes (go-gitea#36431) fix: Improve image captcha contrast for dark mode (go-gitea#36265) Refactor template render (go-gitea#36438) Add documentation for markdown anchor post-processing (go-gitea#36443) Fix markup heading parsing, fix emphasis parsing (go-gitea#36284) Front port changelog for 1.25.4 (go-gitea#36432) Bugfix: Potential incorrect runID in run status update (go-gitea#36437) Restrict branch naming when new change matches with protection rules (go-gitea#36405)
|
This commit does not seem to be back ported into 1.25. Can anyone tell me if I’m wrong or what can I do? |
Because many changes depend new code which is only in 1.26 (main branch), then it's impossible to do a clean backport Which fix do you need? Or you can simply use the nightly build: |
|
@wxiaoguang Thanks! I'm using a custom theme from catppuccin/gitea currently. If I ran 1.25.5, code:not(.code-inner) {
/* ... */
background-color: var(--color-label-bg);
}will take precedence of .markup code {
/* ... */
background-color: var(--color-markup-code-inline);
}In default theme, difference between two colors are not quite much, and both colors looks fine. But so is not this custom theme - inline code in Markdown (like README.md or comments in a PR request) is hard to read. Maybe see catppuccin/gitea#77 for screenshots or fernvenue's Gitea instance for real. (@fernvenue) I searched for After the CSS selector change, the precedence exchanges, and the theme seems to work like before. So what I want is changes on |

Uh oh!
There was an error while loading. Please reload this page.