Skip to content

Update JS dependencies, adjust webpack config, misc fixes#36431

Merged
silverwind merged 16 commits intogo-gitea:mainfrom
silverwind:deps-108
Jan 24, 2026
Merged

Update JS dependencies, adjust webpack config, misc fixes#36431
silverwind merged 16 commits intogo-gitea:mainfrom
silverwind:deps-108

Conversation

@silverwind
Copy link
Copy Markdown
Member

@silverwind silverwind commented Jan 22, 2026

  1. Upgrade to jQuery 4.0. Two of the removed APIs are in use by fomantic, but there are polyfills present so it continues to work.
  2. Remove manual naming of webpack chunks. I was running into below webpack error and I see no reason for this manual chunk naming which is prone to naming collisions. Also, the webpack build now shows all output assets. This change will result in longer asset filenames, but webpack should now be able to guarentee that the names are without collisions.
    ERROR in SplitChunksPlugin
    Cache group "defaultVendors" conflicts with existing chunk.
    Both have the same name "--------" and existing chunk is not a parent of the selected modules.
    Use a different name for the cache group or make sure that the existing chunk is a parent (e. g. via dependOn).
    HINT: You can omit "name" to automatically create a name.
    BREAKING CHANGE: webpack < 5 used to allow to use an entrypoint as splitChunk. This is no longer allowed when the entrypoint is not a parent of the selected modules.
    Remove this entrypoint and add modules to cache group's 'test' instead. If you need modules to be evaluated on startup, add them to the existing entrypoints (make them arrays). See migration guide of more info.
    
  3. Fix test issue related to p > div which is invalid as per HTML spec because div is not phrasing content and therefor can not be a descendant of p. This is related to fix: [#1949] Implement implicit closing of <p> elements per HTML spec capricorn86/happy-dom#2007.
  4. Add webpack globals
  5. Remove obsolete docs glob
  6. fix security issue for seroval package
  7. disable vitest isolate for 30% faster JS tests, which are all pure.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 22, 2026
@silverwind silverwind changed the title Update JS dependencies, adjust webpack config Update JS dependencies, adjust webpack config, fix test issue Jan 22, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates JavaScript dependencies and simplifies webpack configuration to resolve build issues and maintain compatibility with modern libraries.

Changes:

  • Upgrades jQuery from 3.7.1 to 4.0.0 with existing polyfills in Fomantic UI ensuring backward compatibility
  • Simplifies webpack chunk naming configuration by removing manual naming logic that was causing collisions, delegating to webpack's built-in naming strategy
  • Fixes invalid HTML structure in tests (<p><div><div><div>) to comply with HTML specification requirements for phrasing content

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
webpack.config.ts Removes manual chunk naming functions and splitChunks configuration to prevent naming collisions; removes asset exclusion filters to show all output assets
web_src/js/utils/dom.test.ts Fixes invalid HTML structure where <div> elements incorrectly appeared as children of <p> elements
package.json Updates jQuery to 4.0.0 and minor/patch updates for other dependencies including pnpm, mini-css-extract-plugin, perfect-debounce, vue, and various dev tools
pnpm-lock.yaml Auto-generated lockfile reflecting all dependency updates
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 23, 2026
@silverwind
Copy link
Copy Markdown
Member Author

Updated again, added webpack globals from https://github.com/sindresorhus/globals/releases/tag/v17.1.0, remove obsolete docs glob.

@silverwind silverwind changed the title Update JS dependencies, adjust webpack config, fix test issue Update JS dependencies, adjust webpack config, misc fixes Jan 23, 2026
@silverwind

This comment was marked as resolved.

@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 24, 2026
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Jan 24, 2026
@silverwind silverwind enabled auto-merge (squash) January 24, 2026 07:33
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 24, 2026
@silverwind silverwind merged commit 5925433 into go-gitea:main Jan 24, 2026
24 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Jan 24, 2026
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 24, 2026
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 26, 2026
* giteaofficial/main:
  Normalize guessed languages for code highlighting (go-gitea#36450)
  Add `knip` linter (go-gitea#36442)
  Fix various bugs (go-gitea#36446)
  Update tool dependencies (go-gitea#36445)
  Update JS dependencies, adjust webpack config, misc fixes (go-gitea#36431)
  fix: Improve image captcha contrast for dark mode (go-gitea#36265)
  Refactor template render (go-gitea#36438)
  Add documentation for markdown anchor post-processing (go-gitea#36443)
  Fix markup heading parsing, fix emphasis parsing (go-gitea#36284)
  Front port changelog for 1.25.4 (go-gitea#36432)
  Bugfix: Potential incorrect runID in run status update (go-gitea#36437)
  Restrict branch naming when new change matches with protection rules (go-gitea#36405)
@silverwind silverwind deleted the deps-108 branch March 2, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants