Update JS dependencies, adjust webpack config, misc fixes#36431
Merged
silverwind merged 16 commits intogo-gitea:mainfrom Jan 24, 2026
Merged
Update JS dependencies, adjust webpack config, misc fixes#36431silverwind merged 16 commits intogo-gitea:mainfrom
silverwind merged 16 commits intogo-gitea:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates JavaScript dependencies and simplifies webpack configuration to resolve build issues and maintain compatibility with modern libraries.
Changes:
- Upgrades jQuery from 3.7.1 to 4.0.0 with existing polyfills in Fomantic UI ensuring backward compatibility
- Simplifies webpack chunk naming configuration by removing manual naming logic that was causing collisions, delegating to webpack's built-in naming strategy
- Fixes invalid HTML structure in tests (
<p><div>→<div><div>) to comply with HTML specification requirements for phrasing content
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| webpack.config.ts | Removes manual chunk naming functions and splitChunks configuration to prevent naming collisions; removes asset exclusion filters to show all output assets |
| web_src/js/utils/dom.test.ts | Fixes invalid HTML structure where <div> elements incorrectly appeared as children of <p> elements |
| package.json | Updates jQuery to 4.0.0 and minor/patch updates for other dependencies including pnpm, mini-css-extract-plugin, perfect-debounce, vue, and various dev tools |
| pnpm-lock.yaml | Auto-generated lockfile reflecting all dependency updates |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
techknowlogick
approved these changes
Jan 23, 2026
Member
Author
|
Updated again, added webpack globals from https://github.com/sindresorhus/globals/releases/tag/v17.1.0, remove obsolete |
This reverts commit 143a5f9.
This comment was marked as resolved.
This comment was marked as resolved.
delvh
approved these changes
Jan 24, 2026
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 26, 2026
* giteaofficial/main: Normalize guessed languages for code highlighting (go-gitea#36450) Add `knip` linter (go-gitea#36442) Fix various bugs (go-gitea#36446) Update tool dependencies (go-gitea#36445) Update JS dependencies, adjust webpack config, misc fixes (go-gitea#36431) fix: Improve image captcha contrast for dark mode (go-gitea#36265) Refactor template render (go-gitea#36438) Add documentation for markdown anchor post-processing (go-gitea#36443) Fix markup heading parsing, fix emphasis parsing (go-gitea#36284) Front port changelog for 1.25.4 (go-gitea#36432) Bugfix: Potential incorrect runID in run status update (go-gitea#36437) Restrict branch naming when new change matches with protection rules (go-gitea#36405)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
p > divwhich is invalid as per HTML spec becausedivis not phrasing content and therefor can not be a descendant ofp. This is related to fix: [#1949] Implement implicit closing of <p> elements per HTML spec capricorn86/happy-dom#2007.serovalpackage