Skip to content

Enable bodyclose linter#36168

Merged
silverwind merged 2 commits intogo-gitea:mainfrom
silverwind:bodyclose
Dec 16, 2025
Merged

Enable bodyclose linter#36168
silverwind merged 2 commits intogo-gitea:mainfrom
silverwind:bodyclose

Conversation

@silverwind
Copy link
Copy Markdown
Member

@silverwind silverwind commented Dec 16, 2025

Enabe bodyclose. The only issue in non-test code (services/migrations/dump.go) was a false-positive and I think there are a number of undetected cases, but I guess it's still better than not having it.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 16, 2025
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 16, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 16, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 16, 2025
@silverwind silverwind merged commit 84b74d7 into go-gitea:main Dec 16, 2025
23 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Dec 16, 2025
@silverwind silverwind deleted the bodyclose branch December 16, 2025 13:08
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 17, 2025
* giteaofficial/main:
  Automatic generation of release notes (go-gitea#35977)
  Update chroma to v2.21.0 (go-gitea#36171)
  [skip ci] Updated translations via Crowdin
  Move blame to gitrepo (go-gitea#36161)
  Enable `bodyclose` linter (go-gitea#36168)
  fix nilnil in onedev downloader (go-gitea#36154)
  fix webAuthn insecure error view (go-gitea#36165)
  Some small refactors (go-gitea#36163)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/internal skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/code-linting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants