fix nilnil in onedev downloader#36154
Merged
silverwind merged 4 commits intogo-gitea:mainfrom Dec 16, 2025
Merged
Conversation
Applies the same override as with gogs downloader
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
delvh
approved these changes
Dec 14, 2025
GiteaBot
added
lgtm/need 1
Member
|
I guess it's fine to place unused |
silverwind
approved these changes
Dec 14, 2025
GiteaBot
added
lgtm/done
Contributor
Author
|
it does https://golangci-lint.run/docs/linters/configuration/#nolintlint and we have it on (in fact I added it) Lines 18 to 20 in 1f5237e Lines 49 to 52 in 1f5237e I'm very confused why it didn't complain about the nolint here... |
Member
|
Might be a bug in golangci-lint. |
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 17, 2025
* giteaofficial/main: Automatic generation of release notes (go-gitea#35977) Update chroma to v2.21.0 (go-gitea#36171) [skip ci] Updated translations via Crowdin Move blame to gitrepo (go-gitea#36161) Enable `bodyclose` linter (go-gitea#36168) fix nilnil in onedev downloader (go-gitea#36154) fix webAuthn insecure error view (go-gitea#36165) Some small refactors (go-gitea#36163)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onedev migration never used the migration transport, it now uses it the same way gogs one does
cuts 3 nilnils for #36152