Skip to content

Add permissions tofiles-changed jobs#36142

Merged
techknowlogick merged 1 commit intogo-gitea:mainfrom
silverwind:files-changed
Dec 12, 2025
Merged

Add permissions tofiles-changed jobs#36142
techknowlogick merged 1 commit intogo-gitea:mainfrom
silverwind:files-changed

Conversation

@silverwind
Copy link
Copy Markdown
Member

@silverwind silverwind commented Dec 12, 2025

Followup to #36140. files-changed is a job that imports another workflow via uses statement but CodeQL still complains about lack of permissions on these jobs, so add it. This will fix the remaining 3 CodeQL issues.

`files-changed` is a reusable workflow imported via `used` but
apparently CodeQL still complains about this so add permissions to the
importing workflow as well.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 12, 2025
@silverwind silverwind changed the title Add permissions to reused files-changed workflow Add permissions to workflows that import the files-changed workflow Dec 12, 2025
@silverwind silverwind changed the title Add permissions to workflows that import the files-changed workflow Add permissions to jobs that import the files-changed job Dec 12, 2025
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 12, 2025
@silverwind silverwind changed the title Add permissions to jobs that import the files-changed job Add permissions tofiles-changed jobs Dec 12, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 12, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 12, 2025
@techknowlogick techknowlogick merged commit 3e57ba5 into go-gitea:main Dec 12, 2025
23 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Dec 12, 2025
@silverwind silverwind deleted the files-changed branch December 12, 2025 18:02
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 15, 2025
* giteaofficial/main:
  Remove undocumented support of signing key in the repository git configuration file (go-gitea#36143)
  Enable gocheckcompilerdirectives linter (go-gitea#36156)
  Fix code highlighting on blame page (go-gitea#36157)
  Check user visibility when redirecting to a renamed user (go-gitea#36148)
  Fix bug when viewing the commit diff page with non-ANSI files (go-gitea#36149)
  Refactor `FileTreeItem` type (go-gitea#36137)
  Fix various bugs (go-gitea#36139)
  Fix issue close timeline icon (go-gitea#36138)
  Add permissions to`files-changed` jobs (go-gitea#36142)
  Add explicit permissions to all actions workflows (go-gitea#36140)
  Bump `actions/checkout` to v6 (go-gitea#36136)
  Hide RSS icon when viewing a file not under a branch (go-gitea#36135)
  Fix SVG size calulation, only use `style` attribute (go-gitea#36133)
  Add sorting/filtering to admin user search API endpoint (go-gitea#36112)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants