Skip to content

Fix issue close timeline icon#36138

Merged
techknowlogick merged 2 commits intogo-gitea:mainfrom
silverwind:closelabel
Dec 12, 2025
Merged

Fix issue close timeline icon#36138
techknowlogick merged 2 commits intogo-gitea:mainfrom
silverwind:closelabel

Conversation

@silverwind
Copy link
Copy Markdown
Member

Previously there was a icon mismatch between a issue's label and the timeline close event icon:

Screenshot 2025-12-12 at 16 25 13 Screenshot 2025-12-12 at 16 25 03

This fixes it and the icons match now:

Screenshot 2025-12-12 at 16 25 20

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 12, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Dec 12, 2025
@silverwind silverwind added the type/enhancement An improvement of existing functionality label Dec 12, 2025
Copy link
Copy Markdown
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think issue closed is a terrible octicon as circle slash is much more descriptive. But oh well…

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 12, 2025
@silverwind
Copy link
Copy Markdown
Member Author

silverwind commented Dec 12, 2025

I guess the intend of that icon is to evoke more positivity 😆.

@lunny
Copy link
Copy Markdown
Member

lunny commented Dec 12, 2025

Maybe it depends on why it will be closed which is an unimplemented feature.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 12, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) December 12, 2025 17:39
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 12, 2025
@silverwind
Copy link
Copy Markdown
Member Author

Yes, I think we definitely need to implement close reasons.

@techknowlogick techknowlogick merged commit 3102c04 into go-gitea:main Dec 12, 2025
23 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Dec 12, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 12, 2025
@silverwind silverwind deleted the closelabel branch December 12, 2025 18:24
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 15, 2025
* giteaofficial/main:
  Remove undocumented support of signing key in the repository git configuration file (go-gitea#36143)
  Enable gocheckcompilerdirectives linter (go-gitea#36156)
  Fix code highlighting on blame page (go-gitea#36157)
  Check user visibility when redirecting to a renamed user (go-gitea#36148)
  Fix bug when viewing the commit diff page with non-ANSI files (go-gitea#36149)
  Refactor `FileTreeItem` type (go-gitea#36137)
  Fix various bugs (go-gitea#36139)
  Fix issue close timeline icon (go-gitea#36138)
  Add permissions to`files-changed` jobs (go-gitea#36142)
  Add explicit permissions to all actions workflows (go-gitea#36140)
  Bump `actions/checkout` to v6 (go-gitea#36136)
  Hide RSS icon when viewing a file not under a branch (go-gitea#36135)
  Fix SVG size calulation, only use `style` attribute (go-gitea#36133)
  Add sorting/filtering to admin user search API endpoint (go-gitea#36112)
@wxiaoguang wxiaoguang added type/bug and removed type/enhancement An improvement of existing functionality labels Feb 13, 2026
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants