Skip to content

Move gitea-vet to use go tool#35878

Merged
silverwind merged 5 commits intogo-gitea:mainfrom
silverwind:gotool
Nov 6, 2025
Merged

Move gitea-vet to use go tool#35878
silverwind merged 5 commits intogo-gitea:mainfrom
silverwind:gotool

Conversation

@silverwind
Copy link
Copy Markdown
Member

Add it as a tool dependency, eliminating the need for build.go.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 6, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 6, 2025
@silverwind
Copy link
Copy Markdown
Member Author

The Windows failure is odd, it looks like it's building a wrong tool binary?

go: can't execute /home/runner/.cache/go-build/39/3949e19b7d636f55f80996bcb055a1279c844b9e2849c128656907689f408104-d/gitea-vet.exe -flags: fork/exec /home/runner/.cache/go-build/39/3949e19b7d636f55f80996bcb055a1279c844b9e2849c128656907689f408104-d/gitea-vet.exe: exec format error

@silverwind
Copy link
Copy Markdown
Member Author

Windows issue is fixed, the current failures are unrelated.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 6, 2025
@silverwind silverwind merged commit b2feedd into go-gitea:main Nov 6, 2025
25 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Nov 6, 2025
@silverwind silverwind deleted the gotool branch November 6, 2025 20:09
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 10, 2025
* giteaofficial/main:
  Allow to display embed images/pdfs when SERVE_DIRECT was enabled on MinIO storage (go-gitea#35882)
  Add proper page title for project pages (go-gitea#35773)
  Use correct form field for allowed force push users in branch protection API (go-gitea#35894)
  Fix team member access check (go-gitea#35899)
  Add ability for local makefile with personal customizations that wouldnt affect remote repo (go-gitea#35836)
  Add toolchain directive to go.mod (go-gitea#35901)
  Display source code downloads last for release attachments (go-gitea#35897)
  Fix conda null depend issue (go-gitea#35900)
  Fix avatar upload error handling (go-gitea#35887)
  Move `gitea-vet` to use `go tool` (go-gitea#35878)
  Contribution heatmap improvements (go-gitea#35876)
  Update to go 1.25.4 (go-gitea#35877)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/go Pull requests that update Go code modifies/internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants