Skip to content

Update to go 1.25.4#35877

Merged
silverwind merged 1 commit intogo-gitea:mainfrom
silverwind:go1254
Nov 6, 2025
Merged

Update to go 1.25.4#35877
silverwind merged 1 commit intogo-gitea:mainfrom
silverwind:go1254

Conversation

@silverwind
Copy link
Copy Markdown
Member

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 6, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 6, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 6, 2025
@silverwind silverwind merged commit aaa8033 into go-gitea:main Nov 6, 2025
25 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Nov 6, 2025
@silverwind silverwind deleted the go1254 branch November 6, 2025 06:04
@wxiaoguang
Copy link
Copy Markdown
Contributor

CI failure:

758.4 Running go generate...
758.5 go: go.mod requires go >= 1.25.4 (running go 1.25.3; GOTOOLCHAIN=local)
758.5 make: *** [Makefile:755: generate-go] Error 1

@silverwind
Copy link
Copy Markdown
Member Author

Link to run?

@wxiaoguang
Copy link
Copy Markdown
Contributor

All main branch, including this PR's commit

image

@TheFox0x7
Copy link
Copy Markdown
Contributor

@silverwind
Copy link
Copy Markdown
Member Author

silverwind commented Nov 6, 2025

Hmm I think this is because the alpine image still has the old version. I wonder whether we should move to declare go versions in two parts:

go 1.25.0
toolchain go1.25.4

This should make go download the requested toolchain on demand an we basically specify >= 1.25.0 is the minimum version, but this might be problematic for some security scanners.

@silverwind
Copy link
Copy Markdown
Member Author

Another option would be to set GOTOOLCHAIN=auto to enable toolchain downloads. For some reason these builds run with GOTOOLCHAIN=local which inhibits downloads.

@silverwind
Copy link
Copy Markdown
Member Author

Opened #35883.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 10, 2025
* giteaofficial/main:
  Allow to display embed images/pdfs when SERVE_DIRECT was enabled on MinIO storage (go-gitea#35882)
  Add proper page title for project pages (go-gitea#35773)
  Use correct form field for allowed force push users in branch protection API (go-gitea#35894)
  Fix team member access check (go-gitea#35899)
  Add ability for local makefile with personal customizations that wouldnt affect remote repo (go-gitea#35836)
  Add toolchain directive to go.mod (go-gitea#35901)
  Display source code downloads last for release attachments (go-gitea#35897)
  Fix conda null depend issue (go-gitea#35900)
  Fix avatar upload error handling (go-gitea#35887)
  Move `gitea-vet` to use `go tool` (go-gitea#35878)
  Contribution heatmap improvements (go-gitea#35876)
  Update to go 1.25.4 (go-gitea#35877)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants