Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CfTurnstileSitekey context data to all captcha templates #31874

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

bohde
Copy link
Contributor

@bohde bohde commented Aug 19, 2024

In the OpenID flows, the "CfTurnstileSitekey" wasn't populated, which caused those flows to fail if using Turnstile as the Captcha implementation.

This adds the missing context variables, allowing Turnstile to be used in the OpenID flows.

In the OpenID flows, the "CfTurnstileSitekey" wasn't populated, which
caused those flows to fail if using Turnstile as the Captcha implementation.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 19, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 19, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Aug 19, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 19, 2024
@techknowlogick techknowlogick added type/bug lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. backport/v1.22 This PR should be backported to Gitea 1.22 and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 19, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 19, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 19, 2024
@lunny lunny enabled auto-merge (squash) August 19, 2024 17:07
@lunny lunny merged commit 0d24c9f into go-gitea:main Aug 19, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Aug 19, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Aug 19, 2024
…a#31874)

In the OpenID flows, the "CfTurnstileSitekey" wasn't populated, which
caused those flows to fail if using Turnstile as the Captcha
implementation.

This adds the missing context variables, allowing Turnstile to be used
in the OpenID flows.
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Aug 19, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 20, 2024
* giteaofficial/main:
  add CfTurnstileSitekey context data to all captcha templates (go-gitea#31874)
  Add tag name in the commits list (go-gitea#31082)
  Fix actions notify bug (go-gitea#31866)
  Actions support workflow dispatch event (go-gitea#28163)
silverwind pushed a commit that referenced this pull request Aug 20, 2024
…#31876)

Backport #31874 by @bohde

In the OpenID flows, the "CfTurnstileSitekey" wasn't populated, which
caused those flows to fail if using Turnstile as the Captcha
implementation.

This adds the missing context variables, allowing Turnstile to be used
in the OpenID flows.

Co-authored-by: Rowan Bohde <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants