Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag name in the commits list #31082

Merged
merged 11 commits into from
Aug 19, 2024
Merged

Add tag name in the commits list #31082

merged 11 commits into from
Aug 19, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented May 26, 2024

Fix #10036

This PR adds some labels for tags of this commit after the commit message on the commits table. The tag template is share as commit graph's.

Desktop:
image

Mobile:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 26, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 26, 2024
@lunny lunny added the type/enhancement An improvement of existing functionality label May 26, 2024
@lunny lunny added this to the 1.23.0 milestone May 26, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels May 26, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 26, 2024
@lunny lunny marked this pull request as ready for review May 26, 2024 04:43
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 27, 2024
@silverwind
Copy link
Member

Do we have other places where we can re-use that new subtemplate? I think commit graph likely has similar tags, but with a border there (I think I like a border on these).

@lunny
Copy link
Member Author

lunny commented May 28, 2024

Do we have other places where we can re-use that new subtemplate? I think commit graph likely has similar tags, but with a border there (I think I like a border on these).

aebfe5c use the shared tag name template with commit graph.

@silverwind
Copy link
Member

silverwind commented May 29, 2024

Thanks, it does need some style adjustments, the icon makes it too big. Can check later, maybe remove icon. Also I wonder what the significance of the blue border is.

@yp05327
Copy link
Contributor

yp05327 commented Jun 4, 2024

Should we also show tags in mobile views? It looks not good.
If you commit with a long message and a few tags, I think this will be a disaster

@silverwind
Copy link
Member

#31160 will rewrite the commits table and make a lot of space for this, so I think we should wait on that to land here.

@lunny lunny marked this pull request as draft June 13, 2024 01:21
@lunny
Copy link
Member Author

lunny commented Aug 19, 2024

#31160 will rewrite the commits table and make a lot of space for this, so I think we should wait on that to land here.

I don't think #31160 could be merged at a short time. So I think maybe this can be merged first.

@lunny lunny marked this pull request as ready for review August 19, 2024 04:21
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 19, 2024
routers/web/repo/commit.go Outdated Show resolved Hide resolved
routers/web/repo/commit.go Outdated Show resolved Hide resolved
Copy link
Contributor

@yp05327 yp05327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can improve the mobile view later.

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 19, 2024
@lunny lunny enabled auto-merge (squash) August 19, 2024 16:01
@lunny lunny merged commit ccf7366 into go-gitea:main Aug 19, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 19, 2024
@lunny lunny deleted the lunny/commit_tags branch August 19, 2024 18:34
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 20, 2024
* giteaofficial/main:
  add CfTurnstileSitekey context data to all captcha templates (go-gitea#31874)
  Add tag name in the commits list (go-gitea#31082)
  Fix actions notify bug (go-gitea#31866)
  Actions support workflow dispatch event (go-gitea#28163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/migrations modifies/templates This PR modifies the template files modifies/translation size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Git tag support in commits history
7 participants