-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overflowing content in action run log #31842
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Aug 16, 2024
pull-request-size
bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Aug 16, 2024
delvh
approved these changes
Aug 16, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Aug 16, 2024
delvh
added
type/bug
topic/ui
Change the appearance of the Gitea UI
topic/gitea-actions
related to the actions of Gitea
labels
Aug 16, 2024
lunny
approved these changes
Aug 16, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Aug 16, 2024
lunny
added
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
and removed
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
labels
Aug 16, 2024
GiteaBot
added
the
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
label
Aug 16, 2024
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Aug 17, 2024
When a long line with characters such as dots is returned by a step in an action (e.g. by the output of the Ruby on Rails test runner), it overflows the log container, causing the page to scroll sideways. This PR adds the CSS `overflow-wrap: anywhere;` to the `.job-step-section .job-step-logs .job-log-line .log-msg` selector, which causes such lines to wrap as well
GiteaBot
added
backport/done
All backports for this PR have been created
and removed
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
labels
Aug 17, 2024
wolfogre
pushed a commit
that referenced
this pull request
Aug 18, 2024
Backport #31842 by @Adrian-Hirt When a long line with characters such as dots is returned by a step in an action (e.g. by the output of the Ruby on Rails test runner), it overflows the log container, causing the page to scroll sideways (see first screenshot): ![before](https://github.com/user-attachments/assets/d71a8446-2c81-42d7-ad20-92514884365a) This PR adds the CSS `overflow-wrap: anywhere;` to the `.job-step-section .job-step-logs .job-log-line .log-msg` selector, which causes such lines to wrap as well (see second screenshot in which the line wraps nicely): ![after](https://github.com/user-attachments/assets/ba9abaec-dc0b-4fab-8129-b9341d4bf784) Co-authored-by: Adrian Hirt <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 19, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin [skip ci] Updated translations via Crowdin Fix overflowing content in action run log (go-gitea#31842) Upgrade `htmx` to `2.0.2` (go-gitea#31847) fix the component of access token list not mounted (go-gitea#31824) Avoid returning without written ctx when posting PR (go-gitea#31843) Fix raw wiki links (go-gitea#31825)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/done
All backports for this PR have been created
backport/v1.22
This PR should be backported to Gitea 1.22
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/js
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
topic/gitea-actions
related to the actions of Gitea
topic/ui
Change the appearance of the Gitea UI
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a long line with characters such as dots is returned by a step in an action (e.g. by the output of the Ruby on Rails test runner), it overflows the log container, causing the page to scroll sideways (see first screenshot):
This PR adds the CSS
overflow-wrap: anywhere;
to the.job-step-section .job-step-logs .job-log-line .log-msg
selector, which causes such lines to wrap as well (see second screenshot in which the line wraps nicely):