Fix raw wiki links #31825
Merged
Fix raw wiki links #31825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
pull-request-size
bot
added
size/L
lunny
reviewed
Aug 14, 2024
lunny
approved these changes
Aug 14, 2024
GiteaBot
added
lgtm/need 1
wolfogre
approved these changes
Aug 16, 2024
GiteaBot
added
lgtm/done
wolfogre
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Aug 16, 2024
Fix go-gitea#31395 This regression is introduced by go-gitea#30273. To find out how GitHub handles this case, I did [some tests](go-gitea#31395 (comment)). I use redirect in this PR instead of checking if the corresponding `.md` file exists when rendering the link because GitHub also uses redirect. With this PR, there is no need to resolve the raw wiki link when rendering a wiki page. If a wiki link points to a raw file, access will be redirected to the raw link.
GiteaBot
added
backport/done
lunny
added a commit
that referenced
this pull request
Aug 17, 2024
Backport #31825 by @Zettat123 Fix #31395 This regression is introduced by #30273. To find out how GitHub handles this case, I did [some tests](#31395 (comment)). I use redirect in this PR instead of checking if the corresponding `.md` file exists when rendering the link because GitHub also uses redirect. With this PR, there is no need to resolve the raw wiki link when rendering a wiki page. If a wiki link points to a raw file, access will be redirected to the raw link. --------- Co-authored-by: Zettat123 <[email protected]> Co-authored-by: yp05327 <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 19, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin [skip ci] Updated translations via Crowdin Fix overflowing content in action run log (go-gitea#31842) Upgrade `htmx` to `2.0.2` (go-gitea#31847) fix the component of access token list not mounted (go-gitea#31824) Avoid returning without written ctx when posting PR (go-gitea#31843) Fix raw wiki links (go-gitea#31825)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31395
This regression is introduced by #30273. To find out how GitHub handles this case, I did some tests.
I use redirect in this PR instead of checking if the corresponding
.mdfile exists when rendering the link because GitHub also uses redirect. With this PR, there is no need to resolve the raw wiki link when rendering a wiki page. If a wiki link points to a raw file, access will be redirected to the raw link.