Fix null requested_reviewer from API

[emrebdr]

If the assign the pull request review to a team, it did not show the members of the team in the "requested_reviewers" field, so the field was null. As a solution, I added the team members to the array.

fix #31764

[kemzeb]

Thanks for the contribution!

I think it maybe better to create a separate array field in the DTO object for requested teams (similar to GitHub, see here).

To me this makes more sense performance-wise (e.g. there can be many members in a team and, if I'm not mistaken, there may be multiple teams reviewing a PR; this is maybe too much data for us to send that consumers may not care much about).

I guess it makes sense logically too since we aren't requesting a review from individual team members but rather the team as a whole. This shouldn't be a breaking change either.

[emrebdr]

Thanks for the contribution!

I think it maybe better to create a separate array field in the DTO object for requested teams (similar to GitHub, see here).

To me this makes more sense performance-wise (e.g. there can be many members in a team and, if I'm not mistaken, there may be multiple teams reviewing a PR; this is maybe too much data for us to send that consumers may not care much about).

I guess it makes sense logically too since we aren't requesting a review from individual team members but rather the team as a whole. This shouldn't be a breaking change either.

so you mean create a separate array in response object for teams right? And this array field returns teams information? 🤔

[kemzeb]

so you mean create a separate array in response object for teams right? And this array field returns teams information? 🤔

Yes

[emrebdr]

then I think now better.

Ready for review