Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Details about pull request reviewers that are groups are not returned from the API #31764

Closed
dmach opened this issue Aug 2, 2024 · 0 comments · Fixed by #31773
Closed

Details about pull request reviewers that are groups are not returned from the API #31764

dmach opened this issue Aug 2, 2024 · 0 comments · Fixed by #31773
Labels
topic/api Concerns mainly the API type/enhancement An improvement of existing functionality
Milestone
1.23.0

Comments

@dmach
Copy link

dmach commented Aug 2, 2024

Description

  1. create a pull request
  2. assign the pull request review to a group
  3. query the API, for example: curl -H "Token: ..." -X GET https://demo.gitea.com/api/v1/repos/dmach-org/test/pulls/1
    this results in:
{
    ...
    requested_reviewers":[null],
    ...
}

It works fine when the review is assigned to a person.

Gitea Version

1.22.1

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

openSUSE

How are you running Gitea?

openSUSE package running in podman (a container for test purposes)

Database

SQLite
@dmach dmach added the type/bug label Aug 2, 2024
@emrebdr emrebdr mentioned this issue Aug 3, 2024
Merged
@lunny lunny added type/enhancement An improvement of existing functionality topic/api Concerns mainly the API and removed type/bug labels Aug 5, 2024
@lunny lunny added this to the 1.23.0 milestone Aug 5, 2024
wolfogre pushed a commit that referenced this issue Aug 5, 2024
@emrebdr
Fix null requested_reviewer from API (#31773)
94cca88 
If the assign the pull request review to a team, it did not show the
members of the team in the "requested_reviewers" field, so the field was
null. As a solution, I added the team members to the array.

fix #31764
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/api Concerns mainly the API type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.23.0
Development

Successfully merging a pull request may close this issue.

Fix null requested_reviewer from API emrebdr/gitea
2 participants
@lunny @dmach