Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set owner id to zero when GetRegistrationToken for repo #31725

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

wolfogre
Copy link
Member

Fix #31707.

It's split from #31724.

Although #31724 could also fix #31707, it has change a lot so it's not a good idea to backport it.

@wolfogre wolfogre added type/bug topic/gitea-actions related to the actions of Gitea backport/v1.22 This PR should be backported to Gitea 1.22 labels Jul 29, 2024
@wolfogre wolfogre added this to the 1.23.0 milestone Jul 29, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 29, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 29, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jul 29, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 29, 2024
@lafriks lafriks enabled auto-merge (squash) July 29, 2024 18:18
@lafriks lafriks merged commit 81fa471 into go-gitea:main Jul 29, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jul 29, 2024
Fix go-gitea#31707.

It's split from go-gitea#31724.

Although go-gitea#31724 could also fix go-gitea#31707, it has change a lot so it's not a
good idea to backport it.
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jul 29, 2024
wolfogre added a commit that referenced this pull request Jul 30, 2024
)

Backport #31725 by @wolfogre

Fix #31707.

It's split from #31724.

Although #31724 could also fix #31707, it has change a lot so it's not a
good idea to backport it.

Co-authored-by: Jason Song <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 30, 2024
* giteaofficial/main:
  Set owner id to zero when GetRegistrationToken for repo (go-gitea#31725)
  fix(api): owner ID should be zero when created repo secret (go-gitea#31715)
  Fix API endpoint for registration-token (go-gitea#31722)
  Fix loadRepository error when access user dashboard (go-gitea#31719)
  Add permission check when creating PR (go-gitea#31033)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/gitea-actions related to the actions of Gitea type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runner registration token via API is broken for repo level runners
4 participants