Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix API endpoint for registration-token #31722

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Fix API endpoint for registration-token #31722

merged 2 commits into from
Jul 29, 2024

Conversation

wolfogre
Copy link
Member

Partially fix #31707. Related to #30656.

@wolfogre wolfogre added type/bug topic/api Concerns mainly the API backport/v1.22 This PR should be backported to Gitea 1.22 labels Jul 29, 2024
@wolfogre wolfogre added this to the 1.23.0 milestone Jul 29, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 29, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 29, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jul 29, 2024
@wolfogre wolfogre changed the title FIx API endpoint for registration-token Fix API endpoint for registration-token Jul 29, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 29, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) July 29, 2024 16:16
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 29, 2024
@techknowlogick techknowlogick merged commit bf5ae79 into go-gitea:main Jul 29, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jul 29, 2024
@wolfogre @GiteaBot
Fix API endpoint for registration-token (go-gitea#31722)
7f0bd81 
Partially fix go-gitea#31707. Related to go-gitea#30656
@GiteaBot GiteaBot mentioned this pull request Jul 29, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jul 29, 2024
lafriks pushed a commit that referenced this pull request Jul 29, 2024
@GiteaBot @wolfogre
Fix API endpoint for registration-token (#31722) (#31728)
7b37f77 
Backport #31722 by @wolfogre

Partially fix #31707. Related to #30656.

Co-authored-by: Jason Song <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 30, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7057df3 
* giteaofficial/main:
  Set owner id to zero when GetRegistrationToken for repo (go-gitea#31725)
  fix(api): owner ID should be zero when created repo secret (go-gitea#31715)
  Fix API endpoint for registration-token (go-gitea#31722)
  Fix loadRepository error when access user dashboard (go-gitea#31719)
  Add permission check when creating PR (go-gitea#31033)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/api Concerns mainly the API type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Runner registration token via API is broken for repo level runners
4 participants
@wolfogre @lunny @techknowlogick @GiteaBot