-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump vue-bar-graph #31705
bump vue-bar-graph #31705
Conversation
It seems that there was an indirect dependency for "vue-compiler" (the Update: Ideally, there should be no "vue-compiler" for frontend, every Vue component should be compiled when building assets. It was expected that there should be no Vue compiler after #23421. (I am just sharing the background, the vue-compiler problem is not directly related to this PR) |
Yes, runtime dependency on the compiler needs to be removed eventually and moved to webpack, I'm just not sure how to do this as I'm no Vue expert 😆. |
issue created lafriks/vue-bar-graph#18 |
This is now ready for review. |
I was unable to create a backport for 1.22. @techknowlogick, please send one manually. 🍵
|
* giteaofficial/main: Clear up old Actions logs (go-gitea#31735) Fix createElementFromAttrs bug (go-gitea#31751) bump vue-bar-graph (go-gitea#31705) Use UTC as default timezone when schedule Actions cron tasks (go-gitea#31742) Add permission description for API to add repo collaborator (go-gitea#31744) Clarify Actions resources ownership (go-gitea#31724) Exclude protected branches from recently pushed (go-gitea#31748) [skip ci] Updated translations via Crowdin Distinguish LFS object errors to ignore missing objects during migration (go-gitea#31702)
-> scoped-access-token-mount not mounted anymore #31771 Eventually, it is broken |
@wxiaoguang because of the vue bar graph? |
yes |
How? They are not even in the same page 🤔 |
I have explained it #31705 (comment) And you could check out the commit before this PR to test. |
Could it be that vue loads twice or something? I know similar issues with react with components that have dependency on @lafriks I think you should check what the common practices are for publishing vue components. Check other popular components how they do it. |
I have and in vite vue is already set as external library/dependency and are not included in library |
The change should be minimal. I've marked this PR as WIP/draft, as I still need to do local testing, but I wanted to get a PR up as quickly as possible. Please wait to review it until I take it out of draft.