Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSAP incompatible with MIT license, that is included in gitea binaries #31660

Closed
mahlzahn opened this issue Jul 19, 2024 · 7 comments · Fixed by lafriks/vue-bar-graph#15
Closed
Labels

Comments

@mahlzahn
Copy link

Description

GSAP is included as dependency to vue-bar-graph and has a non-free license.

See lafriks/vue-bar-graph#14 and https://codeberg.org/forgejo/discussions/issues/193.

Gitea Version

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Database

None

@mahlzahn mahlzahn changed the title GSAP incompatible with MIT, that is included in gitea builds GSAP incompatible with MIT, that is included in gitea binaries Jul 19, 2024
@mahlzahn mahlzahn changed the title GSAP incompatible with MIT, that is included in gitea binaries GSAP incompatible with MIT license, that is included in gitea binaries Jul 19, 2024
@techknowlogick
Copy link
Member

Thanks again for reporting this, and mentioning it in chat. Looks like the library is only use for one function call: https://github.com/lafriks/vue-bar-graph/blob/6b64270871f43ae8500dbecbcbb5e378ef984574/src/components/VueBarGraph.vue#L294-L297 a temporary workaround could be to remove the animation, and then look at a longer term fix.

@techknowlogick
Copy link
Member

@lafriks if I were to send a PR to your repo with that update, would you be able to cut a new release of it?

@lafriks
Copy link
Member

lafriks commented Jul 19, 2024

@lafriks if I were to send a PR to your repo with that update, would you be able to cut a new release of it?

@techknowlogick sure

@techknowlogick
Copy link
Member

I have a PR now open lafriks/vue-bar-graph#15 which removes gsap entirely.

@delvh
Copy link
Member

delvh commented Jul 20, 2024

Not closed yet, it is only merged into the dependency, not Gitea yet

@delvh delvh reopened this Jul 20, 2024
@lafriks
Copy link
Member

lafriks commented Jul 21, 2024

vue-bar-graph v2.1.0 has been published

@lunny
Copy link
Member

lunny commented Sep 6, 2024

Closed by #31705 and released in 1.22.2

@lunny lunny closed this as completed Sep 6, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants