Fix: Allow org team names of length 255 in create team form #31564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
GiteaBot
added
the
lgtm/need 2
techknowlogick
added
type/bug
backport/v1.22
lunny
approved these changes
Jul 5, 2024
GiteaBot
added
lgtm/need 1
a1012112796
approved these changes
Jul 8, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jul 10, 2024
…#31564) Gitea 1.22.1 was supposed to allow for team names of length 255 (up from 30) after the following PR was merged in: go-gitea#31410. However, the length of team names was still limited to 30 as described in this issue: go-gitea#31554. One more change to _gitea_ needs to be made to allow for the longer team names, as there is a 30 character limit here: https://github.com/go-gitea/gitea/blob/2c92c7c5226e29636a1d47a277130f477fa2037b/services/forms/org.go#L65 This PR changes that value to 255.
GiteaBot
added
backport/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 10, 2024
* giteaofficial/main: Fix: Allow org team names of length 255 in create team form (go-gitea#31564) Remove docs sub folder since docs has been moved to https://gitea.com/gitea/docs (go-gitea#31536) Add bohde as maintainer (go-gitea#31601) Add `YEAR`, `MONTH`, `MONTH_ENGLISH`, `DAY` variables for template repos (go-gitea#31584) Allow disabling authentication related user features (go-gitea#31535) Add back esbuild-loader for .js files (go-gitea#31585)
techknowlogick
pushed a commit
that referenced
this pull request
Jul 10, 2024
…31603) Backport #31564 by @tobiasbp Gitea 1.22.1 was supposed to allow for team names of length 255 (up from 30) after the following PR was merged in: #31410. However, the length of team names was still limited to 30 as described in this issue: #31554. One more change to _gitea_ needs to be made to allow for the longer team names, as there is a 30 character limit here: https://github.com/go-gitea/gitea/blob/2c92c7c5226e29636a1d47a277130f477fa2037b/services/forms/org.go#L65 This PR changes that value to 255. Co-authored-by: Tobias Balle-Petersen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gitea 1.22.1 was supposed to allow for team names of length 255 (up from 30) after the following PR was merged in: #31410. However, the length of team names was still limited to 30 as described in this issue: #31554.
One more change to gitea needs to be made to allow for the longer team names, as there is a 30 character limit here:
gitea/services/forms/org.go
Line 65 in 2c92c7c
This PR changes that value to 255.