Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Length of team names in 1.22.1 is till 30, not 255 #31554

Closed
tobiasbp opened this issue Jul 4, 2024 · 3 comments
Closed

Length of team names in 1.22.1 is till 30, not 255 #31554

tobiasbp opened this issue Jul 4, 2024 · 3 comments
Labels

Comments

@tobiasbp
Copy link
Contributor

tobiasbp commented Jul 4, 2024

Description

Gitea 1.22.1 includes this change:

However, when trying to create a team named cd6fb8d9-17d4-4840-0000-01400a54d260 in 1.22.1, I still get the error message 'Team name must contain at most 30 characters'.

I can reproduce in the Gitea demo by creating an org, and then adding a team to it: https://demo.gitea.com/org/long_team_name_demo_org/teams/new

Gitea Version

1.22.1

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image

Git Version

No response

Operating System

No response

How are you running Gitea?

In Kubernetes with the official Gitea chart. I'm setting image.tag: 1.22.1 as the chart is still using 1.22.0 as of time of writing.

Database

PostgreSQL

@Remmert-PBE
Copy link

Seems there is another length restriction in services/forms:

TeamName string `binding:"Required;AlphaDashDot;MaxSize(30)"`

@tobiasbp
Copy link
Contributor Author

tobiasbp commented Jul 5, 2024

Thanks. I'll make a PR with the proposed change. Thanks.

@tobiasbp
Copy link
Contributor Author

tobiasbp commented Jul 5, 2024

PR added. I'm closing this issue: #31564

@tobiasbp tobiasbp closed this as completed Jul 5, 2024
lunny pushed a commit that referenced this issue Jul 10, 2024
Gitea 1.22.1 was supposed to allow for team names of length 255 (up from
30) after the following PR was merged in:
#31410. However, the length of
team names was still limited to 30 as described in this issue:
#31554.

One more change to _gitea_ needs to be made to allow for the longer team
names, as there is a 30 character limit here:
https://github.com/go-gitea/gitea/blob/2c92c7c5226e29636a1d47a277130f477fa2037b/services/forms/org.go#L65

This PR changes that value to 255.
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jul 10, 2024
…#31564)

Gitea 1.22.1 was supposed to allow for team names of length 255 (up from
30) after the following PR was merged in:
go-gitea#31410. However, the length of
team names was still limited to 30 as described in this issue:
go-gitea#31554.

One more change to _gitea_ needs to be made to allow for the longer team
names, as there is a 30 character limit here:
https://github.com/go-gitea/gitea/blob/2c92c7c5226e29636a1d47a277130f477fa2037b/services/forms/org.go#L65

This PR changes that value to 255.
techknowlogick pushed a commit that referenced this issue Jul 10, 2024
…31603)

Backport #31564 by @tobiasbp

Gitea 1.22.1 was supposed to allow for team names of length 255 (up from
30) after the following PR was merged in:
#31410. However, the length of
team names was still limited to 30 as described in this issue:
#31554.

One more change to _gitea_ needs to be made to allow for the longer team
names, as there is a 30 character limit here:
https://github.com/go-gitea/gitea/blob/2c92c7c5226e29636a1d47a277130f477fa2037b/services/forms/org.go#L65

This PR changes that value to 255.

Co-authored-by: Tobias Balle-Petersen <[email protected]>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Jul 16, 2024
Gitea 1.22.1 was supposed to allow for team names of length 255 (up from
30) after the following PR was merged in:
go-gitea/gitea#31410. However, the length of
team names was still limited to 30 as described in this issue:
go-gitea/gitea#31554.

One more change to _gitea_ needs to be made to allow for the longer team
names, as there is a 30 character limit here:
https://github.com/go-gitea/gitea/blob/2c92c7c5226e29636a1d47a277130f477fa2037b/services/forms/org.go#L65

This PR changes that value to 255.

(cherry picked from commit 4ea2a6de81ab6adde436d77e2743095fafa6a7a9)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants