Fix Safari spinner rendering #29801
Merged
Fix Safari spinner rendering #29801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
silverwind
added
type/bug
backport/v1.21
denyskon
approved these changes
Mar 14, 2024
GiteaBot
added
lgtm/need 1
|
Tested in Safari 17.4 😉 |
techknowlogick
approved these changes
Mar 14, 2024
GiteaBot
added
lgtm/done
techknowlogick
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 14, 2024
Fixes: go-gitea#29041 Fixes: go-gitea#29713 Any of the `width: *-content` properties seem to workaround this Webkit bug, this one seemed most suitable.
GiteaBot
added
backport/done
|
Not sure if 1.20 will see more releases, but this should be a clean merge 😆 |
silverwind
added a commit
that referenced
this pull request
Mar 14, 2024
Backport #29801 by @silverwind Fixes: #29041 Fixes: #29713 Any of the `width: *-content` properties seem to workaround this Webkit bug, this one seemed most suitable. Before: <img width="184" alt="Screenshot 2024-03-14 at 22 29 58" src="https://github.com/go-gitea/gitea/assets/115237/6effc5f0-bc64-4752-be74-9c43b3974407"> After: <img width="177" alt="Screenshot 2024-03-14 at 22 30 30" src="https://github.com/go-gitea/gitea/assets/115237/5de244d7-6b46-428e-957c-4b10f53e2441"> Co-authored-by: silverwind <[email protected]>
|
Ah, I think I may have confused the bot. Well, I assume 1.20 isn't going to get any more releases. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 15, 2024
* giteaofficial/main: Update JS dependences (go-gitea#29797) Unify search boxes (go-gitea#29530) Fix document error about 'make trans-copy' (go-gitea#29710) Remove jQuery AJAX from the diff functions (go-gitea#29743) Fix Safari spinner rendering (go-gitea#29801) Remove jQuery AJAX from the `repo-issue.js` file (go-gitea#29776) Improve commit record's ui in comment list (go-gitea#26619) enable tailwind nesting (go-gitea#29746)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #29041
Fixes: #29713
Any of the
width: *-contentproperties seem to workaround this Webkit bug, this one seemed most suitable.Before:
After:
