Remove jQuery AJAX from the repo-issue.js file
#29776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yarden Shoham <[email protected]>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
yardenshoham
added
the
type/refactoring
silverwind
reviewed
Mar 13, 2024
silverwind
reviewed
Mar 13, 2024
| } | ||
| let data; | ||
| try { | ||
| data = await response?.json(); // the response is probably not a JSON |
There was a problem hiding this comment.
Move line into above try imho and remove the ?.
There was a problem hiding this comment.
The response isn't a JSON though
There was a problem hiding this comment.
Can we find out what responses are possible?
There was a problem hiding this comment.
It returns the full page (HTML)
There was a problem hiding this comment.
Always? Then why do we try to parse JSON? :D
There was a problem hiding this comment.
Which demons did we summon now?
And why does this sound like HTMX to me?
There was a problem hiding this comment.
I thought about it but the URL is dynamic and we don't replace content, we reload. It's certainly possible but I'd have to add some form and inputs and have the HX-Refresh header in the response so I decided it's not worth it
silverwind
reviewed
Mar 13, 2024
silverwind
reviewed
Mar 13, 2024
Co-authored-by: silverwind <[email protected]>
silverwind
reviewed
Mar 13, 2024
silverwind
reviewed
Mar 13, 2024
silverwind
reviewed
Mar 13, 2024
silverwind
reviewed
Mar 13, 2024
silverwind
reviewed
Mar 13, 2024
silverwind
reviewed
Mar 13, 2024
silverwind
reviewed
Mar 13, 2024
silverwind
reviewed
Mar 13, 2024
silverwind
reviewed
Mar 13, 2024
silverwind
reviewed
Mar 13, 2024
Co-authored-by: silverwind <[email protected]>
delvh
reviewed
Mar 13, 2024
| } | ||
| let data; | ||
| try { | ||
| data = await response?.json(); // the response is probably not a JSON |
There was a problem hiding this comment.
Which demons did we summon now?
And why does this sound like HTMX to me?
delvh
approved these changes
Mar 13, 2024
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
silverwind
removed
the
reviewed/wait-merge
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 15, 2024
* giteaofficial/main: Update JS dependences (go-gitea#29797) Unify search boxes (go-gitea#29530) Fix document error about 'make trans-copy' (go-gitea#29710) Remove jQuery AJAX from the diff functions (go-gitea#29743) Fix Safari spinner rendering (go-gitea#29801) Remove jQuery AJAX from the `repo-issue.js` file (go-gitea#29776) Improve commit record's ui in comment list (go-gitea#26619) enable tailwind nesting (go-gitea#29746)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all jQuery AJAX calls and replaced with our fetch wrapper.
Tested the following functionalities and they work as before:
Demo using
fetchinstead of jQuery AJAXUpdating the due-date of an issue
Deleting a comment
Updating a branch in a pull request
Checking and unchecking the "Allow edits from maintainers" checkbox
Requesting review and removing review request
Toggling the WIP status of a pull request
Clicking the new code comment button on the diff page
Editing the issue title and target branch