Display all organization from user settings #1739
Conversation
|
New UI with the last commit:
|
tboerger
added
the
lgtm/need 2
lunny
added
the
type/feature
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM, but I have not tried building this yet. |
tboerger
added
lgtm/done
|
Since it's a new feature, please merge this after v1.2 released |
| {{template "base/alert" .}} | ||
| <h4 class="ui top attached header"> | ||
| {{.i18n.Tr "settings.orgs"}} | ||
| <div class="ui right"> |
There was a problem hiding this comment.
I think there should be if to check if user has rights to create organizations
There was a problem hiding this comment.
True, I will make a new commit for that.
bkcsoft
added
the
status/blocked
options/locale/locale_fr-FR.ini
Outdated
| @@ -274,6 +274,7 @@ applications=Applications | |||
| orgs=Organisations | |||
| delete=Supprimer le compte | |||
| twofa=Authentification à deux facteurs | |||
| organization = Organisation | |||
There was a problem hiding this comment.
I removed french translation
routers/user/setting.go
Outdated
| func SettingsOrganization(ctx *context.Context) { | ||
| ctx.Data["Title"] = ctx.Tr("settings") | ||
| ctx.Data["PageIsSettingsOrganization"] = true | ||
| orgs, err := models.GetOrgsByUserID(ctx.User.ID, ctx.IsSigned && ctx.User.IsAdmin) |
There was a problem hiding this comment.
My mistake, it should not be here. I pushed a new commit.
|
Other than my question, looks good. Why the |
|
For my point of view, it's faster to create that way. |
|
@DblK Builds fail, other than that we should be ready to merge :) |
|
Thanks for the review. Build failed because of time limit exceeded. Could you restart it? |
|
@DblK you can also commit --amend or rebase to restart a build. |
|
@lunny Sorry for merged this PR in |
lunny
removed
the
status/blocked
This PR implement the display of all organizations that the current member is in.
Here are the UI modifications:
Feel free to comment. This is a port of a PR I made for gogs.