Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting orgs #3587

Merged
merged 6 commits into from
Jan 28, 2017
Merged

Setting orgs #3587

merged 6 commits into from
Jan 28, 2017

Conversation

DblK
Copy link
Contributor

@DblK DblK commented Sep 2, 2016

This is the first step for resolving #3532 by implements a new menu "Organizations" under User.Settings.
It display all the organizations that the current user is member and allow also to create a new organization.

image

image

image

image

@unknwon
Copy link
Member

unknwon commented Sep 2, 2016

Thanks, but

  1. We don't need create organization UI inside this page, instead redirect to the proper page.
  2. I prefer the way GitHub displays organizations..

image

@unknwon unknwon added the status: needs feedback Tell me more about it label Sep 2, 2016
@DblK
Copy link
Contributor Author

DblK commented Sep 2, 2016

Hi. Thanks for your reply.
I'm not part on any organization on Github so I didn't know how to display it.
I will modify the template according to the screenshot.

I understand the fact to redirect to the page of the new organization button.
How should it act for the leave button?

@unknwon
Copy link
Member

unknwon commented Sep 3, 2016

How should it act for the leave button?

You can leave this part to me, it's a bit hard to explain..

@DblK
Copy link
Contributor Author

DblK commented Sep 3, 2016

Okay, I will make the change and commit them when finished.
My question about the leave button was about:

  • Should it be a link to redirect to the correct page
    or
  • an implementation in this page like I did for "New Organization" aka handling leaving organization within this page?

After your implementation and the merge of the PR, I will continue on the "Transform %s into an organization" feature. Before developing, I will post some idea of implementation to be sure to go in the wanted way.

@unknwon
Copy link
Member

unknwon commented Sep 4, 2016

@DblK

an implementation in this page like I did for "New Organization" aka handling leaving organization within this page?

similar, but UI work is hard to explain..

@DblK
Copy link
Contributor Author

DblK commented Sep 5, 2016

Here is the new UI:
image

and when there are at least 2 orgs:
image

Now, when you click on "New Organization", it will redirect to the create organization page.

@unknwon
Copy link
Member

unknwon commented Sep 8, 2016

Thanks, will review ASAP.

@unknwon unknwon added status: waits for review It is waiting to be reviewed by maintainers and removed status: needs feedback Tell me more about it labels Sep 8, 2016
@unknwon unknwon added this to the 0.10.0 milestone Dec 23, 2016
@unknwon unknwon merged commit 2ee0c61 into gogs:develop Jan 28, 2017
@appleboy
Copy link
Contributor

@DblK Could you mind port this feature to Gitea?

unknwon added a commit that referenced this pull request Jan 28, 2017
User is now able to view full list of organizations belongs to.
@DblK
Copy link
Contributor Author

DblK commented May 17, 2017

@appleboy done ;)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: waits for review It is waiting to be reviewed by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants