Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changes introduce by update of go-swagger. #1727

Merged
merged 1 commit into from
Jun 2, 2017

Conversation

sapk
Copy link
Member

@sapk sapk commented May 14, 2017

Related to #1719 (that wasn't completely fixed) and #1722 (following)

I also added the same fix for cycling dependencies (in repository obj parent) not handled by swagger-ui

@lunny lunny added this to the 1.2.0 milestone May 15, 2017
@lunny lunny added the type/bug label May 15, 2017
@lunny
Copy link
Member

lunny commented May 25, 2017

Is this ready to review?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 25, 2017
@sapk
Copy link
Member Author

sapk commented May 25, 2017

@lunny yes

@lunny
Copy link
Member

lunny commented May 26, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 26, 2017
@appleboy
Copy link
Member

appleboy commented Jun 2, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 2, 2017
@appleboy appleboy merged commit 976c2a0 into go-gitea:master Jun 2, 2017
@sapk sapk deleted the fix-swagger-diff-2 branch June 17, 2017 17:13
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants