-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public/swagger.v1.json to .gitignore? #1719
Comments
I think that swagger file should be in git. It's generated via go generate and based on specific comments and if no change are made there it should stay the same. I think of it like css and less file but maybe we could separate it build from go generate and have a specific make task. Can you give a example of what trigger a change in the json ? (because it hasn't occur in PR since it was introduce) |
I didn't change anything in the branch. Just built on fresh branch from master today. You can see the difference in the linked gist. Might just be some recent PRs that should have checked in new revisions. |
Quickly looking that should come from #1687 and go-gitea/go-sdk#58 that updated some api response format and not regenerated swagger (make generate). I will make a quick PR to fix that. |
Also #1668 go-gitea/go-sdk#56. |
I'm still still getting a few differences when compiling 91417e9
|
You are right updating go-swagger result to have the same change in json ... |
And since repo contain link to a other repo i think i will have to do the same fix to limit recursive bug in swagger. |
Change made in go-swagger/go-swagger#994. I will have to do an other PR. sorry ^^ |
[x]
): N/Ahttps://gist.github.com/cez81/c5248b900e4588285806c4f854aeadc5
Description
Should public/swagger.v1.json be removed and added to .gitignore? Or should it be checked in after modifying the API? It's modified during compilation even though I haven't changed anything in the current branch.
The text was updated successfully, but these errors were encountered: