Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent empty div when editing comment (#12404) #12992

Closed
wants to merge 1 commit into from
Closed

Prevent empty div when editing comment (#12404) #12992

wants to merge 1 commit into from

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 30, 2020 •
edited
Loading

Backport #12404
close #12895

@zeripath @6543
Prevent empty div when editing comment (go-gitea#12404)
cb8f603 
* Prevent empty div when editing comment

The template for attachments needs to remove whitespace and return empty when there are no attachments.

Fix go-gitea#10220
@6543 6543 added the type/bug label Sep 30, 2020
@6543 6543 mentioned this pull request Sep 30, 2020
Merged
@6543 6543 added this to the 1.12.5 milestone Sep 30, 2020
@6543
Copy link
Member Author

6543 commented Sep 30, 2020

was not first .. -> #12991

@6543 6543 closed this Sep 30, 2020
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 30, 2020
@6543 6543 deleted the backport_fix-10220-no-empty-attachments-div_12404 branch September 30, 2020 23:10
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/bug
Projects
None yet
Milestone
1.12.5
Development

Successfully merging this pull request may close these issues.
3 participants
@6543 @GiteaBot @zeripath