Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing comment leaves empty div segment #10220

Closed
2 of 7 tasks
proton-ab opened this issue Feb 10, 2020 · 4 comments · Fixed by #12404
Closed
2 of 7 tasks

Editing comment leaves empty div segment #10220

proton-ab opened this issue Feb 10, 2020 · 4 comments · Fixed by #12404
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug

Comments

@proton-ab
Copy link
Contributor

  • Gitea version (or commit ref): 1.11.0
  • Git version: -
  • Operating system: -
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist: -

Description

When editing comment, upon submission, div element with classes ui bottom attached segment is created/left. The element of course disappears on page refresh.

Screenshots

After editing:
firefox_2020-02-10_21-56-30
Before editing:
firefox_2020-02-10_21-56-44
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Mar 24, 2020
@stale
Copy link

stale bot commented May 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label May 23, 2020
@proton-ab
Copy link
Contributor Author

Not stale, still applicable.

@stale stale bot removed the issue/stale label May 23, 2020
@stale
Copy link

stale bot commented Jul 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Jul 25, 2020
@proton-ab
Copy link
Contributor Author

Not stale, still applicable.

@stale stale bot removed the issue/stale label Aug 1, 2020
@zeripath zeripath added type/bug issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels Aug 1, 2020
zeripath added a commit to zeripath/gitea that referenced this issue Aug 1, 2020
@zeripath
Prevent empty div when editing comment
61b6bad 
The template for attachments needs to remove whitespace and return empty when there are no attachments.

Fix go-gitea#10220

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue Aug 1, 2020
Merged
zeripath added a commit that referenced this issue Aug 4, 2020
@zeripath
Prevent empty div when editing comment (#12404)
33391e0 
* Prevent empty div when editing comment

The template for attachments needs to remove whitespace and return empty when there are no attachments.

Fix #10220
techknowlogick pushed a commit to techknowlogick/gitea that referenced this issue Sep 30, 2020
@zeripath @techknowlogick
Prevent empty div when editing comment (go-gitea#12404)
2a0d107 
* Prevent empty div when editing comment

The template for attachments needs to remove whitespace and return empty when there are no attachments.

Fix go-gitea#10220
@techknowlogick techknowlogick mentioned this issue Sep 30, 2020
Merged
6543 pushed a commit to 6543-forks/gitea that referenced this issue Sep 30, 2020
@zeripath @6543
Prevent empty div when editing comment (go-gitea#12404)
cb8f603 
* Prevent empty div when editing comment

The template for attachments needs to remove whitespace and return empty when there are no attachments.

Fix go-gitea#10220
lunny pushed a commit that referenced this issue Oct 1, 2020
@techknowlogick @zeripath
Prevent empty div when editing comment (#12404) (#12991)
c1c5e00 
* Prevent empty div when editing comment

The template for attachments needs to remove whitespace and return empty when there are no attachments.

Fix #10220

Co-authored-by: zeripath <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent empty div when editing comment zeripath/gitea
3 participants
@lafriks @zeripath @proton-ab