Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double borders on edit page (#1152) #1153

Merged
merged 2 commits into from
Mar 10, 2017
Merged

Fix double borders on edit page (#1152) #1153

merged 2 commits into from
Mar 10, 2017

Conversation

pgaskin
Copy link
Contributor

@pgaskin pgaskin commented Mar 9, 2017

There is unnecessary double borders around the editors on the edit file view. This applies to both the markdown and the plain text editor. This also makes the editor more consistent with GitHub and the rest of the Gitea UI.

Screenshots

Before my CSS After my CSS
Before my CSS After my CSS

@pgaskin pgaskin mentioned this pull request Mar 9, 2017
2 tasks
@lunny lunny added this to the 1.2.0 milestone Mar 9, 2017
@lunny lunny added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Mar 9, 2017
@appleboy
Copy link
Member

appleboy commented Mar 9, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 9, 2017
@tboerger
Copy link
Member

tboerger commented Mar 9, 2017

This won't be merged unless you apply the changes to the less file. Otherwise the changes will be lost if somebody regenerates the stylesheets.

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 9, 2017

@tboerger fixed. Thanks. I always forget about that.

@tboerger
Copy link
Member

tboerger commented Mar 9, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 9, 2017
@lunny lunny merged commit 5463640 into go-gitea:master Mar 10, 2017
@pgaskin pgaskin deleted the patch-2 branch March 10, 2017 18:45
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants