Double borders on edit file view

[pgaskin]

• Gitea version (or commit ref):
• Git version:
• Operating system:
• Database (use [x]):
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (Just edit any file)
• Log gist: Not relevant

Description

There is unnecessary double borders around the editors on the edit file view. This applies to both the markdown and the plain text editor.

This CSS code will fix it:

.repository.file.editor .tab[data-tab="write"] {
    padding: 0 !important;
}
.repository.file.editor .tab[data-tab="write"] .editor-toolbar {
    border: none !important;
}
.repository.file.editor .tab[data-tab="write"] .CodeMirror {
    border-left: none;
    border-right: none;
    border-bottom: none;
}

Screenshots

Before modifications	After modifications

[lunny]

Why change the style? How the new one is better than old one?

[pgaskin]

The new one is more clean, and saves space. It is also more consistent with GitHub and the rest of the Gitea UI.

[pgaskin]

I have submitted PR #1153

[pgaskin]

@lunny, could this go into 1.1.0, or is that one finished for now?

[lunny]

I think this should not be taken to v1.1, or we will never address 1.1. 1.1 has only 1 bug left.