Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix span wrapping all the things #1043

Merged
merged 1 commit into from
Feb 25, 2017
Merged

Fix span wrapping all the things #1043

merged 1 commit into from
Feb 25, 2017

Conversation

andrew-boyarshin
Copy link
Contributor

@andrew-boyarshin andrew-boyarshin commented Feb 24, 2017 •
edited
Loading

As it is in the title. Wrap in <span> only if text contains link to autolink. Fixes double sized table borders. Ready as it is. Fixes regression introduced in #186.

@andrew-boyarshin
Fix span wrapping all the things
817710d 
Signed-off-by: Andrew Boyarshin <[email protected]>
@lunny
Copy link
Member

lunny commented Feb 24, 2017

For example?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 24, 2017
@lunny lunny added this to the 1.1.0 milestone Feb 24, 2017
@lunny lunny added the type/bug label Feb 24, 2017
@andrew-boyarshin
Copy link
Contributor Author

@lunny https://try.gitea.io/STALKER_2010/wine-staging/wiki, notice horizontal table borders. Double sized compared to the ones before my PR #186.

@andrew-boyarshin
Copy link
Contributor Author

And most likely, it was also the reason why display: block worked badly with table headers after my PR. Spans were also inserted even between tags, even when there was no text there.

@lunny
Copy link
Member

lunny commented Feb 24, 2017

Out of the topic. Do you know https://try.gitea.io/STALKER_2010/wine-staging/wiki the right sidebar seems not correct?

@andrew-boyarshin
Copy link
Contributor Author

andrew-boyarshin commented Feb 24, 2017 •
edited
Loading

@lunny yes, I noticed it long ago, when I was working on #186 PR version for Gogs, yet I didn't work on that. It must be tabulation (or spacing, whatever), that drives blackfriday crazy. As far as I have found out, blackfriday works with list items incorrectly when list items do not start at the beginning of the line. Most likely, it is also the cause of #411.

@lunny
Copy link
Member

lunny commented Feb 24, 2017

trusted LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 24, 2017
@andrew-boyarshin
Copy link
Contributor Author

Anyone willing to review?

@andreynering
Copy link
Contributor

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 25, 2017
@andreynering andreynering merged commit d4a7040 into go-gitea:master Feb 25, 2017
@andrew-boyarshin andrew-boyarshin deleted the autolink branch February 25, 2017 12:58
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@andrew-boyarshin @lunny @andreynering @tboerger