Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown file can not show exactly when ``` start or end with a blank line #411

Closed
1 task done
lotus-king opened this issue Dec 19, 2016 · 12 comments
Closed
1 task done
Labels
status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR topic/ui Change the appearance of the Gitea UI type/bug

Comments

@lotus-king
Copy link

lotus-king commented Dec 19, 2016

Description

put this markdown file https://try.gitea.io/lotus-king/tls/src/master/openssl.md to gogs or gitea .
gogs or gitea cannot correctly show the markdown file, it just show the markdown source file at code (``` start or end with a blank line) ,but github can show it correctly.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@lotus-king lotus-king changed the title Markdown file can not show exactly when ``` start or end with a blank Markdown file can not show exactly when ``` start or end with a blank line Dec 19, 2016
@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels Dec 19, 2016
@lunny lunny added this to the 1.1.0 milestone Dec 19, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Dec 25, 2016

@lotus-king could you try running it through blackfriday directly and see if that works? otherwise it's an upstream bug 🙁

@lunny
Copy link
Member

lunny commented Feb 24, 2017

This is not resolved by #186 also. @andrew-boyarshin :) let's move it to v1.2

@lunny lunny modified the milestones: 1.2.0, 1.1.0 Feb 24, 2017
@andrew-boyarshin
Copy link
Contributor

@lunny If I'm not very much mistaken I've already pointed out that this markdown file has multiple issues and blackfriday is not responsible for fixing invalid markdown.

@lunny lunny modified the milestones: 1.x.x, 1.2.0 Mar 3, 2017
@lunny lunny added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Mar 3, 2017
@ethantkoenig
Copy link
Member

This issues seems to be fixed (https://try.gitea.io/ethantkoenig/sandbox/src/master/README.md). Someone please close

@lunny
Copy link
Member

lunny commented Aug 27, 2017

see https://try.gitea.io/lotus-king/tls/src/master/openssl.md, it seems the problem is not fixed?

@ethantkoenig
Copy link
Member

@lunny As far as I can tell, that's how it should be rendered. I don't see any ``` blocks that aren't being rendered.

@lunny
Copy link
Member

lunny commented Aug 27, 2017

It ignored " ```".

@ethantkoenig
Copy link
Member

@lunny Oh, I see

@bkcsoft
Copy link
Member

bkcsoft commented Aug 27, 2017

It misses it because of invalid indentation. See https://try.gitea.io/bkc/tls/src/master/openssl.md and specifically https://try.gitea.io/bkc/tls/commit/c22378418a700bba1380581be58dc04320b29340

Closing as NotABug 🙂

@bkcsoft bkcsoft closed this as completed Aug 27, 2017
@lunny
Copy link
Member

lunny commented Aug 28, 2017

@bkcsoft But github could render it correctly.

@bkcsoft
Copy link
Member

bkcsoft commented Aug 28, 2017

@lunny GitHub is not using the same markdown renderer as we do, and in any case it's an upstream issue and not an issue with Gitea itself. And the point still stands that the example given is invalid syntax (invalid indentation)

@lunny
Copy link
Member

lunny commented Aug 28, 2017

@bkcsoft OK.

@lunny lunny removed this from the 1.x.x milestone Sep 20, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

No branches or pull requests

5 participants