-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cookbook Uploads #253
Open
wheatevo
wants to merge
2
commits into
go-chef:master
Choose a base branch
from
wheatevo:add-cookbook-upload
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Cookbook Uploads #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for cookbook uploads (V0 and V2). * Add support for chefignore files * Improve metadata.rb parsing to conform with Chef API * Add ServerApiVersion customization to http * Minor linting changes for newer golang versions Resolves go-chef#250
Closed
At this point all integration tests pass with the exception of the following unrelated tests:
Taking a closer look at master branch test results to ensure this isn't a regression. EDIT: Confirmed that this is present in master as well. |
That's not likely to be something you caused. |
I was stuck for a while on #249. I'll get to this PR within the next couple weeks. |
Working on this one now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my first pass at adding cookbook uploads to go-chef/chef.
Changes:
Resolves #250
Both unit and integration tests have been added for the new features. Please take a look and let me know what you think.