Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to override server version #249

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

misantron
Copy link
Contributor

No description provided.

@MarkGibbons
Copy link
Member

Cool, thank you.

@MarkGibbons
Copy link
Member

I'll get this merged as soon as I can, timing will depend on how hard it is to write and run some integration tests.
Thanks for the added function and the code clean up. Its still the first week of the school quarter so I'm a bit swamped this week.

Note mostly for myself.
Should add integration tests and verify that calls work for both 1.0 and 1.3 versions of authentication. http.go testing.
Any issues using different http configs in 1 go run?? I think I remember there were issues changing options.

@misantron
Copy link
Contributor Author

Our server version is 12.8.0 and we use auth version 1.0 - it works well for us.

@MarkGibbons
Copy link
Member

Sorry, I completely forgot about this one. Will look at it this week.

@MarkGibbons
Copy link
Member

I've been working on and off for a couple months on this one. Testing using the existing integration tests is running into all sorts of go and virtual box related problems. Replacing ioutil with io turns out to have implications. The change really needs to happen, but I need to clean up the kludgy mess of the integration tests. I'm sorry it's taking so long.

MarkGibbons added a commit that referenced this pull request Apr 12, 2024
Feature server version config add changes for PR #249 #minor
@MarkGibbons MarkGibbons merged commit 585f112 into go-chef:master Apr 12, 2024
1 check passed
This was referenced Apr 12, 2024
@misantron misantron deleted the feature-server-version-config branch April 12, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants