Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal display not on top for some platforms #282

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Modal display not on top for some platforms #282

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fd80da
Force modal to front
williameveretteggplant Aug 7, 2024
8760810
Revert "Force modal to front"
williameveretteggplant Aug 8, 2024
dd67057
push modal window to top later in process
williameveretteggplant Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Source/NSApplication.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1677,7 +1677,7 @@ - (NSModalSession) beginModalSessionForWindow: (NSWindow*)theWindow
[theWindow center];
[theWindow setLevel: NSModalPanelWindowLevel];
}
[theWindow orderFrontRegardless];

if ([self isActive] == YES)
{
if ([theWindow canBecomeKeyWindow] == YES)
Expand All @@ -1689,6 +1689,7 @@ - (NSModalSession) beginModalSessionForWindow: (NSWindow*)theWindow
[theWindow makeMainWindow];
}
}
[theWindow orderFrontRegardless];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks reasonable to me. Any thoughts @fredkiefer ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks OK. I have not tested the behaviour but if you have feel free to merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this on Debian 12 and it works properly there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredkiefer per your comment, I am approving this so that @williameveretteggplant can merge.


return theSession;
}
Expand Down
Loading