Modal display not on top for some platforms #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcasa
reviewed
Aug 9, 2024
| @@ -1689,6 +1689,7 @@ - (NSModalSession) beginModalSessionForWindow: (NSWindow*)theWindow | |||
| [theWindow makeMainWindow]; | |||
| } | |||
| } | |||
| [theWindow orderFrontRegardless]; | |||
There was a problem hiding this comment.
This change looks reasonable to me. Any thoughts @fredkiefer ?
There was a problem hiding this comment.
The code change looks OK. I have not tested the behaviour but if you have feel free to merge.
There was a problem hiding this comment.
I have tested this on Debian 12 and it works properly there.
There was a problem hiding this comment.
@fredkiefer per your comment, I am approving this so that @williameveretteggplant can merge.
gcasa
approved these changes
Aug 9, 2024
|
I don't see any way to merge. |
This is one of the reasons I advised not creating forks and accepting my invitation instead. If it was a branch on the repo you would have the option to merge. I will do it for you. One sec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem we have seen is that on some platforms (such as Redhat 8) modal windows, specifically NSAlert, are not reliably appearing above the other windows.
By moving the
orderFrontRegardlesscall to a little later in thebeginModalSessionForWindow:method, this appears to reliably display on top as expected.