generic lookupResources#2
Closed
cce wants to merge 3 commits intogmalouf:account-assets-applications-endpoint-enhancementsfrom
Closed
generic lookupResources#2cce wants to merge 3 commits intogmalouf:account-assets-applications-endpoint-enhancementsfrom
cce wants to merge 3 commits intogmalouf:account-assets-applications-endpoint-enhancementsfrom
Conversation
Author
|
IDK? Easier to read? unsure |
Author
|
This version is pretty nice actually |
algorandskiy
reviewed
Mar 3, 2026
| // resourceAdapter bridges lookupResources with the concrete delta slice and | ||
| // DB getters for a given resource type. These live in this package because | ||
| // ledgercore cannot import trackerdb (circular dependency). | ||
| type resourceAdapter[H, P any, R resourceDeltaRecord[H, P]] interface { |
There was a problem hiding this comment.
I like the idea of adapter, wondering if it can also implement new methods of AssetHoldingDelta and co (GetHoldingValue, etc)
cce
deleted the branch
gmalouf:account-assets-applications-endpoint-enhancements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of having a single implementation of the core of lookupApplicationResources / lookupAssetResources