Skip to content

API: Incorporate deltas in presenting paginated view of assets or applications#6559

Merged
gmalouf merged 14 commits intoalgorand:masterfrom
gmalouf:account-assets-applications-endpoint-enhancements
Mar 5, 2026
Merged

API: Incorporate deltas in presenting paginated view of assets or applications#6559
gmalouf merged 14 commits intoalgorand:masterfrom
gmalouf:account-assets-applications-endpoint-enhancements

Conversation

@gmalouf
Copy link
Copy Markdown
Contributor

@gmalouf gmalouf commented Feb 13, 2026

Summary

Incorporate deltas in presenting paginated view of assets or applications on a per account basis. Includes necessary logic to apply delta changes on top of data queried against database, calculating that the next token returned does not result in missing any entries.

Test Plan

Several test cases were added to cover create/modify/delete combinations between the deltas and persisted view for both assets and applications.

…ions on a per account basis. Includes necessary logic to apply delta changes on top of data queried against database, calculating that the next token returned does not result in missing any entries. Several test cases were added to cover create/modify/delete combinations between the deltas and persisted view.
@gmalouf gmalouf self-assigned this Feb 13, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 64.31925% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.83%. Comparing base (00da5ef) to head (39ba854).
⚠️ Report is 13 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ver/v2/generated/nonparticipating/public/routes.go 0.00% 37 Missing ⚠️
ledger/acctupdates.go 80.11% 23 Missing and 11 partials ⚠️
ledger/ledger.go 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (00da5ef) and HEAD (39ba854). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (00da5ef) HEAD (39ba854)
full_coverage 4 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6559       +/-   ##
===========================================
- Coverage   61.28%   47.83%   -13.45%     
===========================================
  Files         484      646      +162     
  Lines       67803    88209    +20406     
===========================================
+ Hits        41552    42197      +645     
- Misses      22401    43239    +20838     
+ Partials     3850     2773     -1077     
Flag Coverage Δ
full_coverage ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…-participating API space (moving them out from behind the enableExperimentalAPI flag).
@gmalouf gmalouf marked this pull request as ready for review February 14, 2026 13:20
Comment thread ledger/acctupdates.go Outdated
Comment thread ledger/acctupdates.go Outdated
Comment thread ledger/acctupdates.go Outdated
Comment thread ledger/acctupdates.go Outdated
Comment thread ledger/acctupdates.go Outdated
gmalouf and others added 3 commits February 17, 2026 11:51
Co-authored-by: John Jannotti <jannotti@gmail.com>
Co-authored-by: John Jannotti <jannotti@gmail.com>
@gmalouf gmalouf requested a review from jannotti February 17, 2026 16:59
Comment thread ledger/acctupdates.go Outdated
@gmalouf gmalouf closed this Feb 18, 2026
@gmalouf gmalouf reopened this Feb 18, 2026
@gmalouf gmalouf requested review from algorandskiy and cce February 18, 2026 15:38
Comment thread ledger/acctupdates.go Outdated
Comment thread ledger/acctdeltas_test.go Outdated
Comment thread ledger/acctdeltas_test.go Outdated
…d when a holding was deleted. Removed intermediate assetDeltaEntry/appDeltaEntry types in favor of the pre-existing AssetResourceRecord/AppResourceRecord types. Cleaned up delta/db entry if/else merge logic for both assets and applications.
Comment thread ledger/acctdeltas_test.go
algorandskiy
algorandskiy previously approved these changes Feb 20, 2026
Comment thread ledger/acctupdates.go
Comment thread ledger/acctupdates.go
Co-authored-by: Pavel Zbitskiy <65323360+algorandskiy@users.noreply.github.com>
algorandskiy
algorandskiy previously approved these changes Feb 20, 2026
@gmalouf gmalouf requested a review from algorandskiy February 23, 2026 17:55
algorandskiy
algorandskiy previously approved these changes Feb 23, 2026
Comment thread ledger/ledger.go
Comment thread ledger/acctupdates.go
Comment thread ledger/acctupdates.go Outdated
Comment thread ledger/acctupdates.go Outdated
cce added a commit to cce/go-algorand that referenced this pull request Feb 27, 2026
…ipped deltas[0], added missing trackerMu.RLock() guards to LookupAssets and LookupApplications, cleaned up an error return for consistency, and adjusted the tests to use MaxAcctLookback = 0 so deltas[0] contains meaningful data that actually exercises the off-by-one fix.
Comment thread ledger/acctupdates.go Outdated
Comment thread ledger/acctupdates.go Outdated
jannotti
jannotti previously approved these changes Mar 4, 2026
…urce lookup functions aligned (and candidates for eventual consolidation). Two tweaks based on CR feedback made in ledger/acctupdates.go.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants