API: Incorporate deltas in presenting paginated view of assets or applications#6559
Merged
gmalouf merged 14 commits intoalgorand:masterfrom Mar 5, 2026
Conversation
…ions on a per account basis. Includes necessary logic to apply delta changes on top of data queried against database, calculating that the next token returned does not result in missing any entries. Several test cases were added to cover create/modify/delete combinations between the deltas and persisted view.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6559 +/- ##
===========================================
- Coverage 61.28% 47.83% -13.45%
===========================================
Files 484 646 +162
Lines 67803 88209 +20406
===========================================
+ Hits 41552 42197 +645
- Misses 22401 43239 +20838
+ Partials 3850 2773 -1077
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…-participating API space (moving them out from behind the enableExperimentalAPI flag).
jannotti
reviewed
Feb 14, 2026
Co-authored-by: John Jannotti <jannotti@gmail.com>
Co-authored-by: John Jannotti <jannotti@gmail.com>
…licationResources of acctupdates.go.
jannotti
reviewed
Feb 18, 2026
…d when a holding was deleted. Removed intermediate assetDeltaEntry/appDeltaEntry types in favor of the pre-existing AssetResourceRecord/AppResourceRecord types. Cleaned up delta/db entry if/else merge logic for both assets and applications.
algorandskiy
previously approved these changes
Feb 20, 2026
Co-authored-by: Pavel Zbitskiy <65323360+algorandskiy@users.noreply.github.com>
algorandskiy
previously approved these changes
Feb 20, 2026
algorandskiy
previously approved these changes
Feb 23, 2026
cce
reviewed
Feb 27, 2026
cce
reviewed
Feb 27, 2026
cce
reviewed
Feb 27, 2026
cce
reviewed
Feb 27, 2026
cce
added a commit
to cce/go-algorand
that referenced
this pull request
Feb 27, 2026
…ipped deltas[0], added missing trackerMu.RLock() guards to LookupAssets and LookupApplications, cleaned up an error return for consistency, and adjusted the tests to use MaxAcctLookback = 0 so deltas[0] contains meaningful data that actually exercises the off-by-one fix.
jannotti
reviewed
Mar 4, 2026
jannotti
reviewed
Mar 4, 2026
jannotti
previously approved these changes
Mar 4, 2026
…urce lookup functions aligned (and candidates for eventual consolidation). Two tweaks based on CR feedback made in ledger/acctupdates.go.
jannotti
approved these changes
Mar 4, 2026
algorandskiy
approved these changes
Mar 4, 2026
cce
added a commit
to cce/go-algorand
that referenced
this pull request
Mar 6, 2026
This was referenced Mar 10, 2026
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Incorporate deltas in presenting paginated view of assets or applications on a per account basis. Includes necessary logic to apply delta changes on top of data queried against database, calculating that the next token returned does not result in missing any entries.
Test Plan
Several test cases were added to cover create/modify/delete combinations between the deltas and persisted view for both assets and applications.