Skip to content

Conversation

@dhomeier
Copy link
Collaborator

@dhomeier dhomeier commented Aug 9, 2025

Description

Converting setup.cfg to toml and setting up tool.setuptools instead of setup.py, following glue-viz/glue-qt#49.

@dhomeier
Copy link
Collaborator Author

dhomeier commented Aug 9, 2025

pre-commit.ci autofix

@dhomeier
Copy link
Collaborator Author

I am very much clueless why the B905 errors are popping up all of a sudden now, as it has been in the default rules long before, but I'd rather fix all the Ruff failures in #2546.

@dhomeier
Copy link
Collaborator Author

Turns out ZipWithoutExplicitStrict is a Python>=3.10 only thing, but Ruff was not aware of the
python_requires = >=3.10 in setup.cfg even after the minimum version was increased.
Therefore adding the ignore here after all (I suspect most cases should use zip(..., strict=True) really, but that needs further investigation.

@dhomeier
Copy link
Collaborator Author

Giving some envs for Python 3.14 (at rc2 now) a try here; probably needs scientific-python-nightly-wheels for compatible h5py and shapely versions, so py314 might be best left to the dev jobs for now.

@dhomeier
Copy link
Collaborator Author

As we have just removed pre-3.10 support, I think it makes sense to add some 3.14 envs now, but probably should weed out some more older ones. Currently there are 5 extra CI jobs.

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - feel free to weed out some of the older builds if you like, though can also be done in a separate PR.

@dhomeier
Copy link
Collaborator Author

dhomeier commented Sep 9, 2025

I've set up Python rc tests as allowed failures now, as sometimes there are no Pandas nightly wheels available for 3.14 (though Pandas 2.3.2 apparently has an installable wheel for it atm).

@astrofrog astrofrog merged commit 271e16f into glue-viz:main Nov 4, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants