-
Notifications
You must be signed in to change notification settings - Fork 157
Migrate configuration to pyproject.toml #2554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
pre-commit.ci autofix |
|
I am very much clueless why the B905 errors are popping up all of a sudden now, as it has been in the default rules long before, but I'd rather fix all the Ruff failures in #2546. |
|
Turns out ZipWithoutExplicitStrict is a Python>=3.10 only thing, but Ruff was not aware of the |
|
Giving some envs for Python 3.14 (at rc2 now) a try here; probably needs scientific-python-nightly-wheels for compatible h5py and shapely versions, so py314 might be best left to the dev jobs for now. |
|
As we have just removed pre-3.10 support, I think it makes sense to add some 3.14 envs now, but probably should weed out some more older ones. Currently there are 5 extra CI jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - feel free to weed out some of the older builds if you like, though can also be done in a separate PR.
|
I've set up Python rc tests as allowed failures now, as sometimes there are no Pandas nightly wheels available for 3.14 (though Pandas 2.3.2 apparently has an installable wheel for it atm). |
Description
Converting setup.cfg to toml and setting up tool.setuptools instead of setup.py, following glue-viz/glue-qt#49.