Skip to content

Conversation

@pre-commit-ci
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jul 7, 2025

@dhomeier dhomeier requested a review from astrofrog July 9, 2025 16:52
@dhomeier
Copy link
Collaborator

dhomeier commented Jul 9, 2025

@astrofrog I've added a permanent exception for the hundreds of import-outside-top-level errors here – I think they are generally there for a reason the way the code is currently designed; also a specific one for glue.test(no_optional_skip).

For the remaining PLW1641 failures, it seems to make sense for glue.core.fixed_resolution_buffer.AnyScalar to be unhashable as it compares equal to every number, and thus add a per-file ignore as well. Not so sure about glue.core.link_helpers.JoinLink – can you comment on this?

@dhomeier dhomeier force-pushed the pre-commit-ci-update-config branch 2 times, most recently from f3f7f9b to 2f8912c Compare August 14, 2025 14:33
@dhomeier
Copy link
Collaborator

dhomeier commented Aug 14, 2025

I have now set up a __hash__ method for JoinLink; as per the hash documentation, equal hashes do not guarantee equality of their objects.
Correction: studying JoinLink further I concluded that, containing mutable properties like the cidNa, it should not implement __hash__. Reverting that change.

@dhomeier dhomeier force-pushed the pre-commit-ci-update-config branch from 2f8912c to b23ce91 Compare August 15, 2025 12:35
@dhomeier dhomeier merged commit bc77491 into main Aug 15, 2025
25 of 26 checks passed
@dhomeier dhomeier deleted the pre-commit-ci-update-config branch August 15, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants