Repository navigation
Add FieldType.FullName in CloneTo and Fix methods for Field - #424
Merged
Merged
Conversation
Contributor
Author
|
Oh I didn't expect a field with a type |
KirillOsenkov
approved these changes
Jul 9, 2026
Collaborator
|
Looks good to me, thanks! |
Contributor
Author
|
Great, I gonna create a test scenario with prebuild assembly with multiple fields with same name. |
This was referenced Jul 10, 2026
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some possibility to have two fields with same
Nameand different type.This PR updates:
CloneTomethod for field to checkNameandFieldType.FullNamealready exists.Fixmethod for field to find the field usingNameandFieldType.FullName.Before only the
Namewas used.Related to issue: #423