Skip to content

Bug#277 fix one unit test#286

Closed
florian-gandon wants to merge 6 commits into
gluck:masterfrom
florian-gandon:Bug#277-fix-one-unit-test
Closed

Bug#277 fix one unit test#286
florian-gandon wants to merge 6 commits into
gluck:masterfrom
florian-gandon:Bug#277-fix-one-unit-test

Conversation

@florian-gandon

Copy link
Copy Markdown
Contributor

No description provided.

ymalich and others added 6 commits November 6, 2020 18:26
…orms and WPF).

- Fixed problem - Nuget download doesn't work without SecurityProtocolType.Tls12 anymore.
- Added NUnitTestAdapter package to run tests in VS 2019 TestExplorer.
…neratesSameBamlAsSample.

The test is broken sometimes, because AssemblyInfoRecords were not sorted and the order in the list is not is not stable, it can change in some circumstances, but it does mean the Baml is wrong.
Apprently in some cases xcopy doesn't understand two '\' (one provided
by TargetDir) which is making failing
GivenNetCore3WinFormsAppUsesImageResources_MergedCore3WinFormsApplicationRunsSuccessfully
@florian-gandon florian-gandon mentioned this pull request Mar 3, 2021

private void OnLoaded(object sender, RoutedEventArgs routedEventArgs)
{
/*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could uncomment the code?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, yes

@KirillOsenkov KirillOsenkov self-assigned this Dec 28, 2023
@KirillOsenkov

Copy link
Copy Markdown
Collaborator

Thank you, this has been merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants