Bug#277#279
Conversation
…orms and WPF). - Fixed problem - Nuget download doesn't work without SecurityProtocolType.Tls12 anymore. - Added NUnitTestAdapter package to run tests in VS 2019 TestExplorer.
|
"All checks have failed"
Hm.. It seems Gradle must be updated to build new SDK-style NET Core projects. |
Hmm.. may be updating the |
|
I have fixed the build in #281 |
|
Great! Thanks! |
|
Hi, I've merged it from master. #284 Regards, |
Hi, Florian. |
…neratesSameBamlAsSample. The test is broken sometimes, because AssemblyInfoRecords were not sorted and the order in the list is not is not stable, it can change in some circumstances, but it does mean the Baml is wrong.
Hi Florian, |
| private List<BamlRecord> OrderAssemblyInfoRecordsByName(List<BamlRecord> bamlRecords) | ||
| { | ||
| var assemblyRecords = bamlRecords | ||
| .OfType<AssemblyInfoRecord>() |
There was a problem hiding this comment.
I check a bit the unit test failure so out of 19 records only than AssemblyInfoRecord are relevant. Good to know. :-)
There was a problem hiding this comment.
The test has failed sometimes on my laptop because BamlReader.ReadDocument returns AssemblyInfoRecords sorted in the different order: in one case the WindowsBase-assembly base goes first, in another case the PresentationCore.
I don't why, but the logical way to fix it is to sort the AssemblyInfoRecords.
I just put the sorted AssemblyInfoRecords at the end of the list, because the result is used only to compare the an another record list.
| private List<BamlRecord> GetRelevantRecords(BamlDocument document) | ||
| { | ||
| return document.Where(node => !(node is LineNumberAndPositionRecord || node is LinePositionRecord)).ToList(); | ||
| var list = document.Where(node => !(node is LineNumberAndPositionRecord || node is LinePositionRecord)).ToList(); |
There was a problem hiding this comment.
Those checks could be merged with the AssemblyInfoRecord checks.
There was a problem hiding this comment.
I'm not sure I understand your idea here.
There was a problem hiding this comment.
Actually, all good, I missed the fact we put back the rest at line169.
|
I've fixed the other unit test. #286 |
4 participants
Hello,
I'd fixed the problem found in the issue #277.
Would you like to review and merge it into the master?
My changes:
2.1 WindowsFormsTestNetCoreApp - new NET Core WindowsForms application with embedded resources.
2.2 ClassLibraryCore - new NET Core class library with WPF user control using embedded resources .
2.3. WPFSampleApplicationCore - new NET Core WPF using the user control from ClassLibraryCore.
Best regards,
Yury Malich