V2

[papayaah]

Hi @bryanmtl !

here are the changes that I moved out of the glossier code.

[bryanmtl]

Thanks @mickeyren. Are there any specs that go along with these changes?

[papayaah]

@bryanmtl i can imagine writing a spec for the subscription renewal job and checking for the cancellation fields.

Can you grant me admin settings? I like to put this up on travis.org.

[papayaah]

@bryanmtl there's a bunch of errors coming out of the spec suite, even on the master branch but I'm more than halfway through. Just a little setback as I get myself acquainted with state_machines

[bryanmtl]

Hey @mickeyren - I've enabled Travis on this repo. Let me know if you have access now.

[papayaah]

@bryanmtl getting there. I actually had to clean up a bunch of issues on the admin pages, improving the UI along the way. Now has tabs!

So far I've been fixing failing specs and admin pages issues so I still yet to write the specs for the new code that were introduced in this PR.

[papayaah]

bryanmtl specs are green, well sort of. and i've put in a simple spec for the subscription renewal.

There is this one last failing spec that happens only on Travis. It's failing to reach the Stripe gateway.

this is the spec:

before(:each) do
    Stripe.api_key = "sk_test_jTiNI1BxjFxBr4TUqdHefc1f"

    user = create(:user)
    setup_subscriptions_for user
    sign_in_as! user

    my_account = MyAccount::Page.new
    @credit_card = my_account.any_subscription.edit.payment_details
  end

  scenario "displays the current payment info" do
    expect(@credit_card.current_payment_info).to_not be_nil
  end

  scenario "can update payment info" do
    @credit_card.number = "4242424242424242"
    @credit_card.name = "John Doe"
    @credit_card.expiry = "06/20"
    @credit_card.code = "123"

    @credit_card.submit

    expect(@credit_card.current_payment_info).to have_text("4242")
    expect(@credit_card.current_payment_info).to have_text("John Doe")
    expect(@credit_card.current_payment_info).to have_text("6/2020")
  end

it's failing on the last one.

cc @aamyot

[bryanmtl]

@mickeyren Do you need test Stripe credentials to get this passing? Does that spec work for you locally?

[papayaah]

@bryanmtl @aamyot

would you guys mind looking over the strange error?

$ bundle exec rake test_app
Expected string default value for '--rc'; got false (boolean)
rake aborted!
NoMethodError: undefined method `last_comment' for #<Rake::Application:0x000000019a4bf0>

I don't find any trace of last_comment anywhere and the spec suite passes just fine for me locally.