Fix/intl renewal #17
Merged
Fix/intl renewal #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he shipping rates are being calculated for US addresses by default, if the currency is not set in the order. Setting the currency for new orders generated ensures the right shipping methods are pulled to match the customer's address
…e creation of the order
…n's last completed order
hugobast
approved these changes
Jul 20, 2017
app/models/spree/subscription.rb
Outdated
| ) | ||
| # use the subscription's email if present. | ||
| # we are doing it here because the order's callback associate_user! will | ||
| # override the order's email even if we set it during creation |
There was a problem hiding this comment.
What about instead of a comment you extract this part into a well named method?
|
@hugobast @sherryson updated - moved it into a callback instead, but i still left a comment. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hugobast @sherryson
this is ready for CR. the problem earlier is renewal isn't working for Canadian subscriptions because the order's currency is being set to USD.
The changes here will set the subsequent orders to follow the last completed order's currency and store id.
I also surfaced the currency in the admin subscription listing page, similar to our admin orders listing.