Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove ie11 on fallback #1535

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

lifeart
Copy link
Contributor

@lifeart lifeart commented Dec 23, 2023

image
    Benchmark Results Summary    

duration phase no difference [-150ms to 47ms]
renderEnd phase no difference [0ms to 3ms]
render1000Items1End phase estimated improvement -16ms [-24ms to -1ms] OR -1.34% [-2.05% to -0.06%]
clearItems1End phase no difference [-2ms to 3ms]
render1000Items2End phase estimated improvement -15ms [-19ms to -2ms] OR -1.66% [-2.02% to -0.22%]
clearItems2End phase no difference [0ms to 0ms]
render5000Items1End phase no difference [-54ms to 11ms]
clearManyItems1End phase no difference [-4ms to 0ms]
render5000Items2End phase estimated improvement -23ms [-45ms to -1ms] OR -0.6% [-1.2% to -0.03%]
clearManyItems2End phase no difference [-1ms to 2ms]
render1000Items3End phase no difference [-16ms to 0ms]
append1000Items1End phase no difference [-15ms to 0ms]
append1000Items2End phase no difference [-4ms to 2ms]
updateEvery10thItem1End phase no difference [0ms to 0ms]
updateEvery10thItem2End phase no difference [0ms to 0ms]
selectFirstRow1End phase no difference [0ms to 0ms]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [-1ms to 0ms]
removeSecondRow1End phase no difference [0ms to 0ms]
swapRows1End phase no difference [-1ms to 1ms]
swapRows2End phase no difference [-1ms to 1ms]
clearItems4End phase no difference [-2ms to 3ms]
paint phase no difference [0ms to 0ms]

artifact-1.pdf

@lifeart lifeart changed the title [chore] remove ie11 or fallback [chore] remove ie11 on fallback Dec 23, 2023
@lifeart lifeart force-pushed the chore-remove-ie11-on-fallback branch from 7799b79 to e57231e Compare December 23, 2023 21:41
@lifeart lifeart marked this pull request as ready for review December 24, 2023 11:51
@lifeart lifeart force-pushed the chore-remove-ie11-on-fallback branch 2 times, most recently from a839559 to 156d243 Compare December 24, 2023 19:55
@lifeart lifeart force-pushed the chore-remove-ie11-on-fallback branch from 156d243 to e3cd32d Compare December 24, 2023 20:00
@NullVoxPopuli
Copy link
Contributor

thank you for the cleanup! this is great!

@NullVoxPopuli NullVoxPopuli merged commit 22150ac into glimmerjs:main Dec 24, 2023
6 checks passed
@lifeart lifeart deleted the chore-remove-ie11-on-fallback branch December 25, 2023 04:51
NullVoxPopuli added a commit to NullVoxPopuli/ember.js that referenced this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants