[REFACTOR] Integrate DebugRenderTree #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Nov 11, 2020
There was a problem hiding this comment.
Overall seems good, a few high level questions though:
- Can you add tests for this using the highest level APIs possible? (rendering a tree of things, asserting on the deep state of the render tree)
- Can you make a draft PR to Ember showing the integration side (so we can get a feel for how it looks over there)?
- Can you update the PR description to be clearer about what specifically is breaking (e.g. these props / classes were removed/renamed/etc)?
packages/@glimmer/interfaces/lib/components/component-manager.d.ts
Outdated
Show resolved
Hide resolved
packages/@glimmer/opcode-compiler/lib/opcode-builder/helpers/components.ts
Outdated
Show resolved
Hide resolved
pzuraq
force-pushed
the
integrate-debug-render-tree-into-vm
branch
2 times, most recently
from
93ab860
to
f434e15
Compare
|
Here is the integration PR in Ember: emberjs/ember.js#19261 |
Integrates the DebugRenderTree into Glimmer VM directly, so it doesn't have to be managed by individual component managers. Major changes: 1. `getDebugRenderTreeName` API added if managers need to override the name provided by `getDebugName` 2. `getCustomDebugRenderTree` API added, allows managers like `outlet` and `mount` to specify custom render trees via a list of render nodes. 3. TemplateOnly components can now integrate in the render tree without having to optionally have `createArgs` or `createInstance` capabilities.
pzuraq
force-pushed
the
integrate-debug-render-tree-into-vm
branch
from
f434e15
to
d3d097d
Compare
rwjblue
reviewed
Nov 12, 2020
Comment on lines
+133
to
+135
| if (didError !== true) { | ||
| endTrackingTransaction!(); | ||
| } |
There was a problem hiding this comment.
This seems a tad surprising, since runInTrackingTransaction always calls beginTrackingTransaction why wouldn't it always call endTrackingTransaction?
Is it because we already call resetTracking (basically in our callsite)?
There was a problem hiding this comment.
Exactly that. With the current structure of things, there is a case where this can happen unfortunately. I think we can work on restructuring it in the future to make it a bit more bulletproof.
rwjblue
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates the DebugRenderTree into Glimmer VM directly, so it doesn't
have to be managed by individual component managers.
Major changes:
getDebugRenderTreeNameAPI added if managers need to override thename provided by
getDebugNamegetCustomDebugRenderTreeAPI added, allows managers likeoutletand
mountto specify custom render trees via a list of render nodes.having to optionally have
createArgsorcreateInstancecapabilities.
Breaking changes:
env.debugRenderTreehas been made optional, it could potentially be undefined and will not assert if it is notDebugRenderTree#setTemplatehas been removed