[FEATURE] Upstreams the DebugRenderTree to Glimmer VM #19261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
commented
Nov 12, 2020
| @@ -38,6 +39,8 @@ moduleFor( | |||
| helperDefinitionCount: 1, | |||
| // from this.render | |||
| templateCacheMisses: 1, | |||
| // from debugRenderTree | |||
| templateCacheHits: ENV._DEBUG_RENDER_TREE ? 1 : 0, | |||
There was a problem hiding this comment.
These values changed due to the new DebugRenderTree integration looking up templates an additional time
rwjblue
reviewed
Nov 12, 2020
packages/@ember/-internals/glimmer/lib/component-managers/template-only.ts
Show resolved
Hide resolved
packages/@ember/-internals/glimmer/tests/integration/application/debug-render-tree-test.ts
Show resolved
Hide resolved
pzuraq
force-pushed
the
upstream/debug-render-tree-integration
branch
from
873edfe
to
11a5225
Compare
pzuraq
force-pushed
the
upstream/debug-render-tree-integration
branch
from
11a5225
to
91699cc
Compare
rwjblue
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to Glimmer VM 0.64.0 (release notes)