-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrigger Travis build for debugging #25
Commits on Nov 29, 2012
-
Initial attempt to validate context before running filters.
This way developers will see any potential missing context without running the entire filter, which may not ever encounter a case where it needs the context.
Configuration menu - View commit details
-
Copy full SHA for b5852a6 - Browse repository at this point
Copy the full SHA b5852a6View commit details -
Cleaned up context validation. Declared requirements for EmojiFilter.
Declaring required contexts has been simplified. validates_context_presence no longer requires self to be passed in. Instead it will attempt to build the caller name by using Kernel::caller. Tests have been added for filters that require context.
Configuration menu - View commit details
-
Copy full SHA for 1d7c100 - Browse repository at this point
Copy the full SHA 1d7c100View commit details -
Noted in filters if a context is required. Updated README to include info about required contexts.
Configuration menu - View commit details
-
Copy full SHA for b22d39f - Browse repository at this point
Copy the full SHA b22d39fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8dad706 - Browse repository at this point
Copy the full SHA 8dad706View commit details -
Configuration menu - View commit details
-
Copy full SHA for e17e840 - Browse repository at this point
Copy the full SHA e17e840View commit details -
Updated context validation to use a singleton.
Using a singleton to remove the reliance on a class variable. Removed unnecessary calling_class method and just using self instead.
Configuration menu - View commit details
-
Copy full SHA for 53398d3 - Browse repository at this point
Copy the full SHA 53398d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9515424 - Browse repository at this point
Copy the full SHA 9515424View commit details -
Initial attempt to validate context before running filters.
This way developers will see any potential missing context without running the entire filter, which may not ever encounter a case where it needs the context.
Configuration menu - View commit details
-
Copy full SHA for 4b8c3ba - Browse repository at this point
Copy the full SHA 4b8c3baView commit details -
Cleaned up context validation. Declared requirements for EmojiFilter.
Declaring required contexts has been simplified. validates_context_presence no longer requires self to be passed in. Instead it will attempt to build the caller name by using Kernel::caller. Tests have been added for filters that require context.
Configuration menu - View commit details
-
Copy full SHA for 1d831d9 - Browse repository at this point
Copy the full SHA 1d831d9View commit details -
Noted in filters if a context is required. Updated README to include info about required contexts.
Configuration menu - View commit details
-
Copy full SHA for dc9c988 - Browse repository at this point
Copy the full SHA dc9c988View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35f5ec3 - Browse repository at this point
Copy the full SHA 35f5ec3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f4a5fd - Browse repository at this point
Copy the full SHA 2f4a5fdView commit details -
Updated context validation to use a singleton.
Using a singleton to remove the reliance on a class variable. Removed unnecessary calling_class method and just using self instead.
Configuration menu - View commit details
-
Copy full SHA for 3dfa9e9 - Browse repository at this point
Copy the full SHA 3dfa9e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2409e4c - Browse repository at this point
Copy the full SHA 2409e4cView commit details -
Merge branch 'context_validation' of https://github.com/benubois/html…
…-pipeline into context_validation
Configuration menu - View commit details
-
Copy full SHA for 163d081 - Browse repository at this point
Copy the full SHA 163d081View commit details -
Removed declarative code in favor of a validation hook. It's up to subclasses to implement the validate method. Validate will be called by Filter after initialization so @context is available. Reverted README.md to remove the additions about validation.
Configuration menu - View commit details
-
Copy full SHA for b37f5a5 - Browse repository at this point
Copy the full SHA b37f5a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a044dba - Browse repository at this point
Copy the full SHA a044dbaView commit details
Commits on Nov 30, 2012
-
Changed required context method name to 'needs.' Updated needs to use @jbarnette's concise version of needs. Made validate a noop method instead of checking if a filter respond_to? validate.
Configuration menu - View commit details
-
Copy full SHA for 011aa07 - Browse repository at this point
Copy the full SHA 011aa07View commit details