Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrigger Travis build for debugging #25

Merged
merged 18 commits into from
Dec 1, 2012
Merged

Retrigger Travis build for debugging #25

merged 18 commits into from
Dec 1, 2012

Commits on Nov 29, 2012

  1. Initial attempt to validate context before running filters.

    This way developers will see any potential missing context without
    running the entire filter, which may not ever encounter a case where
    it needs the context.
    benubois committed Nov 29, 2012
    Configuration menu
    Copy the full SHA
    b5852a6 View commit details
    Browse the repository at this point in the history
  2. Cleaned up context validation. Declared requirements for EmojiFilter.

    Declaring required contexts has been simplified.
    validates_context_presence no longer requires self to be passed in.
    Instead it will attempt to build the caller name by using
    Kernel::caller.
    
    Tests have been added for filters that require context.
    benubois committed Nov 29, 2012
    Configuration menu
    Copy the full SHA
    1d7c100 View commit details
    Browse the repository at this point in the history
  3. Added required context info.

    Noted in filters if a context is required. Updated README to include info about
    required contexts.
    benubois committed Nov 29, 2012
    Configuration menu
    Copy the full SHA
    b22d39f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8dad706 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e17e840 View commit details
    Browse the repository at this point in the history
  6. Updated context validation to use a singleton.

    Using a singleton to remove the reliance on a class variable.
    
    Removed unnecessary calling_class method and just using self instead.
    benubois committed Nov 29, 2012
    Configuration menu
    Copy the full SHA
    53398d3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9515424 View commit details
    Browse the repository at this point in the history
  8. Initial attempt to validate context before running filters.

    This way developers will see any potential missing context without
    running the entire filter, which may not ever encounter a case where
    it needs the context.
    benubois committed Nov 29, 2012
    Configuration menu
    Copy the full SHA
    4b8c3ba View commit details
    Browse the repository at this point in the history
  9. Cleaned up context validation. Declared requirements for EmojiFilter.

    Declaring required contexts has been simplified.
    validates_context_presence no longer requires self to be passed in.
    Instead it will attempt to build the caller name by using
    Kernel::caller.
    
    Tests have been added for filters that require context.
    benubois committed Nov 29, 2012
    Configuration menu
    Copy the full SHA
    1d831d9 View commit details
    Browse the repository at this point in the history
  10. Added required context info.

    Noted in filters if a context is required. Updated README to include info about
    required contexts.
    benubois committed Nov 29, 2012
    Configuration menu
    Copy the full SHA
    dc9c988 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    35f5ec3 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    2f4a5fd View commit details
    Browse the repository at this point in the history
  13. Updated context validation to use a singleton.

    Using a singleton to remove the reliance on a class variable.
    
    Removed unnecessary calling_class method and just using self instead.
    benubois committed Nov 29, 2012
    Configuration menu
    Copy the full SHA
    3dfa9e9 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    2409e4c View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    163d081 View commit details
    Browse the repository at this point in the history
  16. Switched validation approach.

    Removed declarative code in favor of a validation hook. It's up to subclasses
    to implement the validate method. Validate will be called by Filter after
    initialization so @context is available.
    
    Reverted README.md to remove the additions about validation.
    benubois committed Nov 29, 2012
    Configuration menu
    Copy the full SHA
    b37f5a5 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    a044dba View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2012

  1. Context validation tweaks.

    Changed required context method name to 'needs.' Updated needs to use
    @jbarnette's concise version of needs.
    
    Made validate a noop method instead of checking if a filter respond_to?
    validate.
    benubois committed Nov 30, 2012
    Configuration menu
    Copy the full SHA
    011aa07 View commit details
    Browse the repository at this point in the history